Bug 768802

Summary: Newline validation on leading and trailing string.
Product: [Retired] Zanata Reporter: Alex Eng <aeng>
Component: UsabilityAssignee: Alex Eng <aeng>
Status: CLOSED CURRENTRELEASE QA Contact: Ding-Yi Chen <dchen>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 1.5CC: damason, sflaniga, zanata-bugs
Target Milestone: ---Keywords: UserStory
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-04-23 04:33:15 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Alex Eng 2011-12-19 02:06:35 UTC
Description of problem:

Message strings often contain escape sequences like newlines or tabs and any mismatch in their position or number may result in an error to be generated for the translation file.

This story is just for leading and trailing newline. 

This will be for '\n' sequence.

Comment 1 Alex Eng 2011-12-19 04:17:56 UTC
Implemented in 1.5. See https://github.com/zanata/zanata/commit/d4e942d8d1d6420f561d003c6e181e6744894e87

Comment 2 David Mason 2012-01-06 03:16:24 UTC
Does not detect when newlines are present in the target but not the source. Validation should detect these cases given that any mismatch could result in an error.

Properly detects when leading and trailing newlines are present in the source but not the target.

A number of strings in Hibernate Core have a trailing newline followed by 8 spaces. This looks like a trailing newline but is technically just trailing whitespace and is not reported as missing by this validator - it is unclear how this should be treated, this could require an enhancement in the future for validating arbitrary leading/trailing whitespace.

Comment 4 David Mason 2012-01-19 07:35:00 UTC
 - updated to use localisable message strings
 - updated tag order algorithm to detect single moved tag
 - updated printf matching regex to match most standard variable patterns


Comment 6 David Mason 2012-02-10 04:14:10 UTC
*** Bug 746140 has been marked as a duplicate of this bug. ***