Bug 769056
| Summary: | Review Request: wbox - HTTP testing tool and configuration-less HTTP server | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Othman Madjoudj <athmanem> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 16 | CC: | mail, notting, package-review, veeti.paananen |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-03-03 20:16:26 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 563471 | ||
|
Description
Othman Madjoudj
2011-12-19 19:08:18 UTC
rpmlint output: $ rpmlint wbox.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint wbox-5-1.fc16.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint wbox-5-1.fc16.x86_64.rpm wbox.x86_64: W: no-manual-page-for-binary wbox 1 packages and 0 specfiles checked; 0 errors, 1 warnings. This is my first package and I need a sponsor. Updated with manpage from Debian: Spec URL: http://athmane.fedorapeople.org/pkgs/wbox.spec SRPM URL: http://athmane.fedorapeople.org/pkgs/wbox-5-2.fc16.src.rpm rpmlint output: $ rpmlint wbox.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint wbox-5-2.fc16.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint wbox-5-2.fc16.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Koji scratch build (for x86_64 and i686): http://koji.fedoraproject.org/koji/taskinfo?taskID=3601866 Hi!
Just a few comments/suggestions:
- You could use a macro in the Source0 line: replace the hardcoded version number with %{version} so that you don't need to update it in two places later.
- Do you plan on maintaining this package on EPEL5? If yes, add the BuildRoot as instructed in http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies . Otherwise you can drop the rm -rf %{buildroot} from the beginning of %install, since it's done automatically in newer versions.
(In reply to comment #5) > Hi! > > Just a few comments/suggestions: > > - You could use a macro in the Source0 line: replace the hardcoded version > number with %{version} so that you don't need to update it in two places later. > Fixed, it was a mistake when I was testing. > - Do you plan on maintaining this package on EPEL5? If yes, add the BuildRoot > as instructed in http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies . > Otherwise you can drop the rm -rf %{buildroot} from the beginning of %install, > since it's done automatically in newer versions. I'm not planing to support epel5, so I've removed rm -rf %{buildroot} from %install Thanks for your suggestions. Spec URL: http://athmane.fedorapeople.org/pkgs/wbox.spec SRPM URL: http://athmane.fedorapeople.org/pkgs/wbox-5-3.fc16.src.rpm No longer using this package, closing. *** This bug has been marked as a duplicate of bug 894176 *** |