| Summary: | spindown doesn't spin down after waking from suspend | |||
|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ville Skyttä <ville.skytta> | |
| Component: | spindown | Assignee: | Martin Cermak <mcermak> | |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | |
| Severity: | high | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | 16 | CC: | hdegoede, mcermak | |
| Target Milestone: | --- | Keywords: | Reopened | |
| Target Release: | --- | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | spindown-0.4.0-5.fc16 | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 787231 (view as bug list) | Environment: | ||
| Last Closed: | 2012-03-01 09:20:51 UTC | Type: | --- | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Bug Depends On: | ||||
| Bug Blocks: | 787231 | |||
|
Description
Ville Skyttä
2011-12-19 19:34:12 UTC
You're right. Using your config file I'm able to reproduce the issue.
> I see there's a "repeat" parameter documented at
> http://code.google.com/p/spindown/wiki/Configuration which I haven't tried,
> mainly because I fail to see what good would spindown then be over just
> invoking hdparm -y repeatedly from cron. The /etc/spindown.conf I'm testing
> with is included below.
Yes, you can use "repeat = 1" to work around your problem:
As you can see in Spindown::spinDownIdleDisks(), the daemon periodically checks a condition similar to this one: disk->idleTime() >= disk->spinDownTime().
By default (repeat = 0) the spindown command is called just for the first time this condition is met. With "repeat = 1", the spindown command is called repeatedly each time that condition is met. This resolves your issue.
Closing as NOTABUG. Feel free to reopen if your problem persists.
> I see there's a "repeat" parameter documented at
> http://code.google.com/p/spindown/wiki/Configuration which I haven't tried,
> mainly because I fail to see what good would spindown then be over just
> invoking hdparm -y repeatedly from cron.
I can understand this is not ideal solution, but this is the way the upstream code works. Better solution could probably be based on a hook in /etc/pm/sleep.d. If you like, please file a new request for feature [rfe] against spindown and I can elaborate on this.
spindown-0.4.0-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/spindown-0.4.0-4.fc16 > Better solution could probably be based on a hook in /etc/pm/sleep.d.
Here I come with such a solution.
Package spindown-0.4.0-4.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing spindown-0.4.0-4.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-1177/spindown-0.4.0-4.fc16 then log in and leave karma (feedback). spindown-0.4.0-4.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. (In reply to comment #4) > Here I come with such a solution. I think using "systemctl restart" here is not correct as it will start spindown even if it was not running; try-restart should be used instead, no? spindown-0.4.0-5.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/spindown-0.4.0-5.fc16 Right you are, definitely. Thanks for the response. Please, review the fix and consider giving some karma to the package. Thanks. Done, the F-16 update seems to work for me. But the F-17 and rawhide versions still seem to be doing "systemctl restart". Package spindown-0.4.0-5.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing spindown-0.4.0-5.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-2086/spindown-0.4.0-5.fc16 then log in and leave karma (feedback). > the F-17 and rawhide versions still seem to be doing "systemctl restart". I know; related bz787231 is already reopened. Going to fix that too.. spindown-0.4.0-5.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. |