Bug 769284

Summary: Fails to build with Ruby 1.9.3
Product: [Fedora] Fedora Reporter: Bohuslav "Slavek" Kabrda <bkabrda>
Component: ruby-revolutionAssignee: Mamoru TASAKA <mtasaka>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: mtasaka
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-03-07 12:38:18 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Bohuslav "Slavek" Kabrda 2011-12-20 12:59:43 UTC
Hi,
we are currently in a process of preparing migration to Ruby 1.9.3 and we are
rebuilding all the related packages. ruby-revolution is one of them and it seems that it hasn't been supported by upstream since 2006. Because it fails to build with Ruby 1.9.3 (due to changes in the C API), would you consider retiring it (also, no other packages depend on it, so this shouldn't be a problem)?

Thank you!

Comment 1 Mamoru TASAKA 2011-12-20 14:45:32 UTC
First of all please provide *HOW* build fails.

Comment 2 Mamoru TASAKA 2011-12-20 14:47:49 UTC
(In reply to comment #0)
> Hi,
> we are currently in a process of preparing migration to Ruby 1.9.3 and we are
> rebuilding all the related packages.

Please throw such information to ruby-sig (and what is "we" here?)

Comment 3 Mamoru TASAKA 2011-12-20 14:55:03 UTC
And anyway I cannot fix this because ruby 193 is not there yet.

Comment 4 Bohuslav "Slavek" Kabrda 2011-12-21 06:31:19 UTC
- "We" means me and Vit Ondruch :)
- Ok, for the future, I will throw it to Ruby-SIG.
- There is the testing repo by Vit Ondruch and I believe we should consider retiring some packages (this one, too), because they are no longer maintained by upstream and incompatible with Ruby 1.9.3. If you want to keep it, maybe the best way would be to make the upstream work again or actually become the upstream, otherwise you'll probably have to maintain it yourself.

Comment 5 Bohuslav "Slavek" Kabrda 2011-12-21 06:33:01 UTC
For the HOW the build fails part - it is due to the changes in the C API:

revolution.c: In function 'open_tasks':
revolution.c:142:111: error: 'struct RString' has no member named 'ptr'
revolution.c: In function 'open_calendar':
revolution.c:157:111: error: 'struct RString' has no member named 'ptr'
revolution.c: In function 'revolution_add_task':
revolution.c:351:73: error: 'struct RString' has no member named 'ptr'
revolution.c: In function 'revolution_delete_task':
revolution.c:370:62: error: 'struct RString' has no member named 'ptr'
revolution.c: In function 'revolution_delete_appointment':
revolution.c:449:62: error: 'struct RString' has no member named 'ptr'
revolution.c: In function 'revolution_add_appointment':
revolution.c:466:5: warning: zero-length gnu_printf format string [-Wformat-zero-length]
revolution.c:475:73: error: 'struct RString' has no member named 'ptr'
revolution.c:495:72: error: 'struct RString' has no member named 'ptr'
revolution.c: In function 'revolution_get_appointments_between':
revolution.c:542:71: error: 'struct RString' has no member named 'ptr'
revolution.c:544:67: error: 'struct RString' has no member named 'ptr'
revolution.c: In function 'revolution_get_appointment_by_uid':
revolution.c:567:64: error: 'struct RString' has no member named 'ptr'
revolution.c: In function 'revolution_get_appointments_with_query':
revolution.c:598:103: error: 'struct RString' has no member named 'ptr'
revolution.c: In function 'revolution_get_contacts_with_query':
revolution.c:872:97: error: 'struct RString' has no member named 'ptr'
revolution.c: In function 'revolution_get_contacts_by_name':
revolution.c:885:148: error: 'struct RString' has no member named 'ptr'
revolution.c: In function 'revolution_get_contact_by_uid':
revolution.c:904:67: error: 'struct RString' has no member named 'ptr'
revolution.c: In function 'revolution_delete_contact':
revolution.c:921:90: error: 'struct RString' has no member named 'ptr'
revolution.c: In function 'export_email_addresses':
revolution.c:932:68: error: 'struct RString' has no member named 'ptr'
revolution.c: In function 'string_exporter':
revolution.c:944:87: error: 'struct RString' has no member named 'ptr'
revolution.c: In function 'name_exporter':
revolution.c:952:65: error: 'struct RString' has no member named 'ptr'
revolution.c:956:66: error: 'struct RString' has no member named 'ptr'
revolution.c: In function 'im_exporter':
revolution.c:996:69: error: 'struct RString' has no member named 'ptr'
revolution.c:998:68: error: 'struct RString' has no member named 'ptr'
revolution.c:1000:63: error: 'struct RString' has no member named 'ptr'

Comment 6 Bohuslav "Slavek" Kabrda 2012-03-07 12:38:18 UTC
Closing this issue as ruby-revolution was already built in Koji with Ruby 1.9.3.