Bug 769692

Summary:	Add boundary conditions and overflow detection code in necessary glusterfs library functions
Product:	[Community] GlusterFS	Reporter:	Harshavardhana <fharshav>
Component:	core	Assignee:	Raghavendra Bhat <rabhat>
Status:	CLOSED EOL	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	mainline	CC:	cww, gluster-bugs
Target Milestone:	---	Keywords:	FutureFeature, Tracking
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-10-22 15:46:38 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Harshavardhana 2011-12-21 18:38:16 UTC

Description of problem:

This is placeholder for cleanups in entire glusterfs codebase to ensure proper checks for boundary conditions and overflow detection.

Comment 1 Anand Avati 2012-01-03 21:29:42 UTC

CHANGE: http://review.gluster.com/2556 (libglusterfs: Add boundary conditions to data_to_int8() function.) merged in master by Vijay Bellur (vijay)

Comment 2 Harshavardhana 2012-02-29 15:28:16 UTC

http://review.gluster.com/#change,2599 - Can this change be reviewed and pushed.

Comment 3 Anand Avati 2012-03-18 09:20:37 UTC

CHANGE: http://review.gluster.com/2599 (libglusterfs/dict: Add boundary conditions) merged in master by Anand Avati (avati)

Comment 4 Amar Tumballi 2012-10-19 05:08:58 UTC

marking it ON_DEV... this bug can remain open all the time...

Comment 5 Anand Avati 2013-10-21 04:55:51 UTC

REVIEW: http://review.gluster.org/6115 (libglusterfs: Propositions should be logical) posted (#1) for review on master by Harshavardhana (harsha)

Comment 6 Anand Avati 2013-10-21 06:13:32 UTC

REVIEW: http://review.gluster.org/6115 (libglusterfs: Propositions should be logical) posted (#2) for review on master by Harshavardhana (harsha)

Comment 7 Anand Avati 2013-10-22 01:32:09 UTC

COMMIT: http://review.gluster.org/6115 committed in master by Anand Avati (avati) 
------
commit 34990cf1838fe85d995c15ea25bc0f77bfd66ed6
Author: Harshavardhana <harsha>
Date:   Sun Oct 20 21:45:45 2013 -0700

    libglusterfs: Propositions should be logical
    
    Mutually exclusive tests shouldn't be
    non-contradictory
     -- (A is B) && (A is not B) is not valid
    
    Change-Id: Icf97d1704fedca4b8eeeb67da8b7d4c8d4b578d5
    BUG: 769692
    Signed-off-by: Harshavardhana <harsha>
    Reviewed-on: http://review.gluster.org/6115
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>

Comment 9 Kaleb KEITHLEY 2015-10-22 15:46:38 UTC

because of the large number of bugs filed against mainline version\ is ambiguous and about to be removed as a choice.

If you believe this is still a bug, please change the status back to NEW and choose the appropriate, applicable version for it.