Bug 770279

Summary: [ovirt] [engine-core] create storage domain command gets rollback if createStoragePool doesn't succeed
Product: [Retired] oVirt Reporter: Haim <hateya>
Component: ovirt-engine-coreAssignee: lpeer <lpeer>
Status: CLOSED WONTFIX QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: abaron, acathrow, amureini, iheim, mgoldboi, yeylon, ykaul
Target Milestone: ---   
Target Release: 3.3.4   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: storage
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-12-12 07:32:38 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
engine logs. none

Description Haim 2011-12-25 14:29:55 UTC
Description of problem:

if createStoragePool is executed and doesn't succeed, system performs rollback for createStorageDomain command on engine side, but domain remains on vdsm side.

please do not tie those commands together, domain creation succeeded and there is no need to rollback this command. 

implications:

- web-admin shows no domain in domains list
- host running vdsm is left with volume group (domain) with vdsm TAGs on it. 
- administrator won't be able to use this domain as its not empty. 


- repro steps:
  * createStorageDomain (iscsi)
  * once CreateStoragePool command is executed on enigne side, restart vdsm on 
    host side. 

attached engine logs; 

git 4aedff6b61f714f8e24ccb9efff052e347d8de3f

Comment 1 Haim 2011-12-25 14:32:51 UTC
Created attachment 549482 [details]
engine logs.

For debugging purposes: 

Look for last CreateStoragePool, and prior to that command, look for CreateVdsStorageDomainCommand, and see that it succeeds (FINISH).

Comment 2 Itamar Heim 2012-12-12 07:32:38 UTC
Closing old bugs. If this issue is still relevant/important in current version, please re-open the bug.