Bug 77028

Summary: [PATCH] Remove work-around no longer needed so GDM works w/ Xvnc
Product: [Retired] Red Hat Linux Reporter: Dax Kelson <dkelson>
Component: vncAssignee: Tim Waugh <twaugh>
Status: CLOSED RAWHIDE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: 8.0   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2002-11-08 15:09:05 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Patch Xvnc to remove old work-around no longer needed that causes problems with GDM none

Description Dax Kelson 2002-10-31 04:04:05 UTC
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20021003

Description of problem:
It is possible to configure a display manger to launch Xvnc instead the regular
Xserver. This works with xdm for example, but not with gdm.

Looking into it I found an old hack that was applied to Xvnc to work around a
LinuxThreads bug that is no longer needed. Removing this hack makes Xvnc and gdm
work together.

Here is the patch.

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1.Configure GDM to launch Xvnc
2.Notice that it doesn't work
3.Apply patch, recompile Xvnc, it now works.
	

Actual Results:  n/a

Expected Results:  n/a

Additional info:

diff -ur vnc_unixsrc/Xvnc/programs/Xserver/os/connection.c
vnc_unixsrc-gurulabs/Xvnc/programs/Xserver/os/connection.c
--- vnc_unixsrc/Xvnc/programs/Xserver/os/connection.c   Mon May 11 11:02:17 1998
+++ vnc_unixsrc-gurulabs/Xvnc/programs/Xserver/os/connection.c  Tue Oct 15
16:22:27 2002
@@ -379,7 +379,7 @@
    BEGIN ORL VNC modification
    Don't use SIGUSR1 - linuxthread uses this internally */

-/* REMOVE
+/* no longer true 10/15/02 */
     if (OsSignal (SIGUSR1, SIG_IGN) == SIG_IGN)
    RunFromSmartParent = TRUE;
     ParentProcess = getppid ();
@@ -388,7 +388,6 @@
        kill (ParentProcess, SIGUSR1);
    }
     }
-*/

 /* END ORL VNC modification
 ================================================================*/

Comment 1 Dax Kelson 2002-10-31 04:05:42 UTC
Created attachment 82805 [details]
Patch Xvnc to remove old work-around no longer needed that causes problems with GDM

Comment 2 Tim Waugh 2002-11-21 12:17:18 UTC
Fixed in 3.3.3r2-41, which will appear in rawhide shortly.  Thanks.