Bug 770306
| Summary: | Provide native systemd service | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jóhann B. Guðmundsson <johannbg> | ||||||||||
| Component: | haveged | Assignee: | Jiri Hladky <hladky.jiri> | ||||||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||
| Severity: | unspecified | Docs Contact: | |||||||||||
| Priority: | unspecified | ||||||||||||
| Version: | rawhide | CC: | gwync, hladky.jiri, johannbg | ||||||||||
| Target Milestone: | --- | ||||||||||||
| Target Release: | --- | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Whiteboard: | |||||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||||
| Doc Text: | Story Points: | --- | |||||||||||
| Clone Of: | Environment: | ||||||||||||
| Last Closed: | 2012-02-14 23:00:12 UTC | Type: | --- | ||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||
| Documentation: | --- | CRM: | |||||||||||
| Verified Versions: | Category: | --- | |||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||
| Embargoed: | |||||||||||||
| Bug Depends On: | |||||||||||||
| Bug Blocks: | 751869 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Jóhann B. Guðmundsson
2011-12-25 22:11:14 UTC
Created attachment 549515 [details]
Native systemd unit for havege
Jiri, any objection to my making this change? Hi Jon and Jóhann, I'm sorry for the delay. I was waiting for the new haveged release. Version 1.4 was released just now and I will move it to SystemD. I have checked the attachment - there is one typo but other than that it looks fine. Thanks Jirka Great, thank you! Created attachment 562086 [details]
SPEC File for systemd
SPEC File for systemd
Created attachment 562088 [details]
Systemd service file
Systemd service file
Done:-) You should drop the After=syslog.target it's no longer necessary and fix PIDFile= path to be /run not /var/run which points to the actual path and will not be change while the /var/run symlink might be removed in the not too distant future. Created attachment 562327 [details]
Systemd service file
Thanks for the hints!
I have updated service file accordingly.
(In reply to comment #8) > You should drop the After=syslog.target it's no longer necessary and fix > PIDFile= path to be /run not /var/run which points to the actual path and will > not be change while the /var/run symlink might be removed in the not too > distant future. Hi Johann, I have updated service file but I have one question regarding PID file. Software will by default create PID File at location /var/run/haveged.pid This cannot be changed right now (but I can ask upstream to add such command line option if needed) I have now updated service file to be PIDFile=/run/haveged.pid I have seen that there are now two PID Files created: $ls -l /var/run/haveged.pid /run/haveged.pid -rw-r--r-- 1 root root 4 Feb 15 23:16 /run/haveged.pid -rw-r--r-- 1 root root 4 Feb 15 23:16 /var/run/haveged.pid This is obviously wrong. Could you please clarify what's the right way to handle this? Should PIDFile= be omitted when software is creating PIDFile automatically? Or should PIDFile= match the PID file created by software? Thanks a lot Jirka change the PIDFile= path back to /var/run then check with upstream what they have to say usually there is a configuration file or a compile option that sets the used pid path. Dont forget to submit that unit file upstream as well. You can then just change the PIDFile path later via update or when we create a Feature page for it and various other cleanup stuff. Hi Jóhann, thanks for the clarification. I have inspected the source code, currently there is no way how to influence location of the PID File. I have requested it. I have already sent service file to the upstream as well. Thanks a lot Jirka |