Bug 770433

Summary: [ovirt-engine-core] backend should validate the subnet mask
Product: [Retired] oVirt Reporter: zvi <zfridler>
Component: ovirt-engine-coreAssignee: lpeer <lpeer>
Status: CLOSED DUPLICATE QA Contact:
Severity: low Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: abaron, acathrow, bazulay, iheim, knesenko, yeylon, ykaul
Target Milestone: ---Keywords: EasyFix
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-04-12 00:43:02 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description zvi 2011-12-26 13:43:10 UTC
Description of problem:
VDSM should return an error when defining illegal subnet mask .

Version-Release number of selected component (if applicable):
ic 153.1

How reproducible:

always
Steps to Reproduce:
1.define a NIC or BOND or VLAN with illegal subnet mask ( '255.3.255.3',)
2.
3.
  
Actual results:

the /32 (255.255.255.255) subnet mask is created for that interface
Expected results:
an error message. don't update the interface subnet mask. or if a new interface is being created cancel creation with appropriate error.

Additional info:



Thread-715::DEBUG::2011-12-25 15:23:14,907::clientIF::54::vds::(wrapper) [10.35.97.44]::call setSafeNetworkConfig with () {}
Thread-715::DEBUG::2011-12-25 15:23:14,914::clientIF::59::vds::(wrapper) return setSafeNetworkConfig with {'status': {'message': 'Done', 'code': 0}}
Thread-716::DEBUG::2011-12-25 15:25:16,644::clientIF::54::vds::(wrapper) [10.35.97.44]::call addNetwork with ('KABAB', '', '', ['eth1'], {'STP': 'no', 

'NETMASK': '255.3.255.3', 'IPADDR': '10.35.102.38'}) {}

Thread-716::WARNING::2011-12-25 15:25:16,651::clientIF::1009::vds::(_translateOptionsToNew) options NETMASK is deprecated. Use netmask instead
Thread-716::WARNING::2011-12-25 15:25:16,651::clientIF::1009::vds::(_translateOptionsToNew) options IPADDR is deprecated. Use ipaddr instead
MainProcess|Thread-716::DEBUG::2011-12-25 15:25:16,669::configNetwork::409::root::(addNetwork) validating bridge...
MainProcess|Thread-716::INFO::2011-12-25 15:25:16,690::configNetwork::414::root::(addNetwork) Adding bridge KABAB with vlan=None, bonding=None, nics=['eth1']. bondingOptions=None, options={'STP': 'no'}
MainProcess|Thread-716::DEBUG::2011-12-25 15:25:16,691::configNetwork::188::root::(_persistentBackup) Persistently backed up /etc/sysconfig/network-scripts/ifcfg-KABAB (until next 'set safe config')
MainProcess|Thread-716::DEBUG::2011-12-25 15:25:16,691::configNetwork::142::root::(_atomicBackup) Backed up /etc/sysconfig/network-scripts/ifcfg-eth1
MainProcess|Thread-716::DEBUG::2011-12-25 15:25:16,692::configNetwork::188::root::(_persistentBackup) Persistently backed up /etc/sysconfig/network-scripts/ifcfg-eth1 (until next 'set safe config')
MainProcess|Thread-716::WARNING::2011-12-25 15:25:16,862::configNetwork::58::root::(ifdown) 
Thread-716::DEBUG::2011-12-25 15:25:21,849::clientIF::59::vds::(wrapper) return addNetwork with {'status': {'message': 'Done', 'code': 0}}
Thread-717::DEBUG::2011-12-25 15:25:21,861::clientIF::54::vds::(wrapper) [10.35.97.44]::call getVdsCapabilities with () {}
Thread-717::DEBUG::2011-12-25 15:25:21,883::utils::579::Storage.Misc.excCmd::(execCmd) '/bin/rpm -q --qf "%{NAME}\t%{VERSION}\t%{RELEASE}\t%{BUILDTIME}\n" qemu-kvm' (cwd None)
Thread-717::DEBUG::2011-12-25 15:25:21,912::utils::579:

Comment 2 Kiril Nesenko 2012-02-13 14:16:39 UTC
Subnet mask should be validated on the backend level

Comment 4 Itamar Heim 2012-04-12 00:43:02 UTC

*** This bug has been marked as a duplicate of bug 717652 ***