Bug 770806

Summary: Review Request: gmm - Library to operate on sparse and dense matrices and vectors
Product: [Fedora] Fedora Reporter: Shakthi Kannan <shakthimaan>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: drizt72, notting, package-review, shakthimaan
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-31 07:42:03 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Shakthi Kannan 2011-12-29 09:09:10 UTC
Spec URL: http://shakthimaan.fedorapeople.org/SPECS/gmm.spec
SRPM URL: http://shakthimaan.fedorapeople.org/SRPMS/gmm-4.1-1.fc15.src.rpm
Description: Gmm provides some basic types of sparse and dense matrices and vectors. 
It provides some generic operations on them copy - addition, multiplication, 
sub-vector and sub-matrices, solvers.

Comment 1 Shakthi Kannan 2011-12-29 09:11:25 UTC
$ rpmlint gmm.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpmlint gmm-4.1-1.fc15.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint gmm-4.1-1.fc15.x86_64.rpm 
gmm.x86_64: E: no-binary
gmm.x86_64: E: incorrect-fsf-address /usr/share/doc/gmm-4.1/COPYING
1 packages and 0 specfiles checked; 2 errors, 0 warnings.

$  rpmlint gmm-devel-4.1-1.fc15.x86_64.rpm 
gmm-devel.x86_64: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Successful Koji builds for F15, F16, F17 and EL6:

http://koji.fedoraproject.org/koji/taskinfo?taskID=3608935
http://koji.fedoraproject.org/koji/taskinfo?taskID=3608938
http://koji.fedoraproject.org/koji/taskinfo?taskID=3608941
http://koji.fedoraproject.org/koji/taskinfo?taskID=3608944

Comment 2 Ivan Romanov 2011-12-30 12:52:30 UTC
Hi Shakthi.

Your package haven't any libraries. I couldn't find. But
%package devel
Summary:        Header files and *libraries* for gmm development

What for need gmm subpackage? Maybe should use only one subpackage gmm with headers?

pkgconfig can be dropped from requires.
https://fedoraproject.org/wiki/Packaging/Guidelines#Pkgconfig_Files

use noarch
BuildArch:      noarch

Comment 3 Shakthi Kannan 2011-12-30 16:34:49 UTC
I have removed *libraries* and pkgconfig from the .spec file. 

Added use of BuildArch: noarch.

Spec URL: http://shakthimaan.fedorapeople.org/SPECS/gmm.spec
SRPM URL: http://shakthimaan.fedorapeople.org/SRPMS/gmm-4.1-2.fc15.src.rpm

To sound technically correct, I have placed header files in the -devel subpackage. I will leave the decision to the package reviewer.

Comment 4 Ivan Romanov 2011-12-31 07:08:47 UTC
Do you have allready packages in Fedora?

Comment 5 Shakthi Kannan 2011-12-31 07:12:11 UTC
Yes.

http://rpms.famillecollet.com/rpmphp/all.php?what=shakthimaan

Comment 6 Ivan Romanov 2011-12-31 07:21:35 UTC
Fedora allready has gmm package. 
https://admin.fedoraproject.org/pkgdb/acls/name/gmm

Comment 7 Shakthi Kannan 2011-12-31 07:42:03 UTC
Makes life easier. Bug can be closed.