Bug 771079

Summary:	When quickly adding NICs to a Template the New NIC's Name is like the previous NIC. Race Condition .
Product:	[Retired] oVirt	Reporter:	zvi <zfridler>
Component:	ovirt-engine-webadmin	Assignee:	Einav Cohen <ecohen>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	acathrow, ecohen, iheim, lpeer, Rhev-m-bugs, yeylon, ykaul
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:	network
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-12-16 06:57:32 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description zvi 2011-12-31 21:33:12 UTC

Description of problem:
When adding new NICs quick (not waiting between each NIC creation) the same NIC's name is selected. an error message is shown in the GUI:

Version-Release number of selected component (if applicable):


How reproducible:
Always in VPN settings (GUI <--> RHEVM IP link via VPN)

Steps to Reproduce:

1.Quickly create new NICs to a Template
2.
3.
  
Actual results:
after the ~4th NIC - a new NIC with the previous NIC's name is shown. When Pressing OK an error message is shown:

rhel 6.2 :
network already in use

Expected results:

No error message

Additional info:

GUI issue since the GUI can prevent this error message by adding a check to verify that the previous NIC was added successfully before attempting to create a new NIC.

2011-12-31 22:22:22,342 INFO  [org.ovirt.engine.core.bll.AddVmTemplateInterfaceCommand] (pool-10-thread-1198) Running command: AddVmTemplateInterfaceCommand internal: false. Entities affected :  ID: 16c5f7b4-66ad-4ea8-9d22-b036724e12fa Type: VmTemplate
2011-12-31 22:22:26,117 WARN  [org.ovirt.engine.core.bll.AddVmTemplateInterfaceCommand] (http-0.0.0.0-8443-5) CanDoAction of action AddVmTemplateInterface failed. Reasons:VAR__ACTION__ADD,VAR__TYPE__INTERFACE,NETWORK_INTERFACE_NAME_ALREAY_IN_USE
2011-12-31 22:22:36,282 INFO  [org.ovirt.engine.core.bll.AddVmTemplateInterfaceCommand] (pool-10-thread-1198) Running command: AddVmTemplateInterfaceCommand internal: false. Entities affected :  ID: 16c5f7b4-66ad-4ea8-9d22-b036724e12fa Type: VmTemplate
2011-12-31 22:22:43,317 INFO  [org.ovirt.engine.core.bll.AddVmTemplateInterfaceCommand] (pool-10-thread-1198) Running command: AddVmTemplateInterfaceCommand internal: false. Entities affected :  ID: 16c5f7b4-66ad-4ea8-9d22-b036724e12fa Type: VmTemplate
2011-12-31 22:22:47,360 INFO  [org.ovirt.engine.core.bll.AddVmTemplateInterfaceCommand] (pool-10-thread-1198) Running command: AddVmTemplateInterfaceCommand internal: false. Entities affected :  ID: 16c5f7b4-66ad-4ea8-9d22-b036724e12fa Type: VmTemplate
2011-12-31 22:22:49,991 INFO  [org.ovirt.engine.core.bll.AddVmTemplateInterfaceCommand] (pool-10-thread-1198) Running command: AddVmTemplateInterfaceCommand internal: false. Entities affected :  ID: 16c5f7b4-66ad-4ea8-9d22-b036724e12fa Type: VmTemplate
2011-12-31 22:22:53,768 INFO  [org.ovirt.engine.core.bll.AddVmTemplateInterfaceCommand] (pool-10-thread-1198) Running command: AddVmTemplateInterfaceCommand internal: false. Entities affected :  ID: 16c5f7b4-66ad-4ea8-9d22-b036724e12fa Type: VmTemplate
2011-12-31 22:22:55,588 WARN  [org.ovirt.engine.core.bll.AddVmTemplateInterfaceCommand] (http-0.0.0.0-8443-4) CanDoAction of action AddVmTemplateInterface failed. Reasons:VAR__ACTION__ADD,VAR__TYPE__INTERFACE,NETWORK_INTERFACE_NAME_ALREAY_IN_US

Comment 1 Einav Cohen 2012-01-03 17:44:00 UTC

There will always be some race between adding the new NIC and retrieving the new NIC in the client; the new NIC doesn't even have to be added via the same GUI - in can be added via the user portal, another admin instance or the api.

Not sure if/how to handle; considering to close.

Comment 2 Itamar Heim 2012-01-04 02:39:26 UTC

(In reply to comment #1)
> There will always be some race between adding the new NIC and retrieving the
> new NIC in the client; the new NIC doesn't even have to be added via the same
> GUI - in can be added via the user portal, another admin instance or the api.
> 
> Not sure if/how to handle; considering to close.

that's true for client side validation, not for backend validation.
but I agree the main question is how important is this field name wrt uniqueness to begin with.

Comment 5 Itamar Heim 2012-12-16 06:57:32 UTC

Closing old bugs. If this issue is still relevant/important in current version, please re-open the bug.