Bug 771106

Summary:	The mkinitrd script has a bug on 52d line.
Product:	[Fedora] Fedora	Reporter:	Sergey Khvostov <hso99>
Component:	dracut	Assignee:	Harald Hoyer <harald>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	16	CC:	dracut-maint, extras-orphan, harald, hdegoede, jonathan, notting, wtogami
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-01-23 10:29:09 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Sergey Khvostov 2012-01-01 12:44:00 UTC

Description of problem:
If you try ti rebuild initrd by mkinitrd script, you get following message:
/sbin/mkinitrd: line 52: read_args: command not found

How reproducible:
# mkinitrd --preload scsi_mod,sd_mod,libata,ahci,ehci-hcd,ohci-hcd,uhci-hcd,jbd,ext3,ata_piix,ext4 /boot/initramfs-3.1.6-1.fc16.x86_64.img.1 3.1.6-1.fc16.x86_64
/sbin/mkinitrd: line 52: read_args: command not found

  
Actual results:
Hanging during execution.

Expected results:
It must create initrd. )

Additional info:
The problem in following: the script has read_arg() function definition, but on line 52 it try to execute read_args function.
Solution is to edit line 52 and remove "s" in function calling.

Comment 1 Harald Hoyer 2012-01-05 09:57:23 UTC

Thanks for the finding... BUT ...

"mkinitrd --preload" will not really preload those modules. They are just included in the initramfs and not force loaded.

Better add a permanent configuration for dracut (mkinitrd replacement):

# echo 'add_drivers+=" scsi_mod sd_mod libata ahci ehci-hcd ohci-hcd uhci-hcd jbd ext3 ata_piix ext4 "' >> /etc/dracut.conf.d/99-mydrivers.conf

and add to the kernel command line:

rd.driver.pre=scsi_mod,sd_mod,libata,ahci,ehci-hcd,ohci-hcd,uhci-hcd,jbd,ext3,ata_piix,ext4

Comment 2 Sergey Khvostov 2012-01-05 19:12:32 UTC

Hello.

Thanks for your comment regarding "--preload" key and dracut. 
I'm talk not about dracut, but for mkinitrd.

Regarding bug: no metter with wich keys we're running mkinitrd script, in all cases we get error: "/sbin/mkinitrd: line 52: read_args: command not found".
As I said the fix of that problem is very easy, but it requaried some scripting skills. I'd like to see fixing of that problem in some of updates (not sure wich package including mkinitrd script). BTW, all updates at that time were installed.

In case of mkinitrd replacement, mkinitrd scipt must be EOLed or redirect to dracut or somewhere alse. Are you agree? ;) That's why I asking you to fix that problem for all Fedora users.

Thanks a lot.

Have a good day.

Comment 3 Sergey Khvostov 2012-01-05 19:12:58 UTC

Hello.

Thanks for your comment regarding "--preload" key and dracut. 
I'm talk not about dracut, but for mkinitrd.

Regarding bug: no metter with wich keys we're running mkinitrd script, in all cases we get error: "/sbin/mkinitrd: line 52: read_args: command not found".
As I said the fix of that problem is very easy, but it requaried some scripting skills. I'd like to see fixing of that problem in some of updates (not sure wich package including mkinitrd script). BTW, all updates at that time were installed.

In case of mkinitrd replacement, mkinitrd scipt must be EOLed or redirect to dracut or somewhere alse. Are you agree? ;) That's why I asking you to fix that problem for all Fedora users.

Thanks a lot.

Have a good day.

Comment 4 Sergey Khvostov 2012-01-05 19:13:17 UTC

Hello.

Thanks for your comment regarding "--preload" key and dracut. 
I'm talk not about dracut, but for mkinitrd.

Regarding bug: no metter with wich keys we're running mkinitrd script, in all cases we get error: "/sbin/mkinitrd: line 52: read_args: command not found".
As I said the fix of that problem is very easy, but it requaried some scripting skills. I'd like to see fixing of that problem in some of updates (not sure wich package including mkinitrd script). BTW, all updates at that time were installed.

In case of mkinitrd replacement, mkinitrd scipt must be EOLed or redirect to dracut or somewhere alse. Are you agree? ;) That's why I asking you to fix that problem for all Fedora users.

Thanks a lot.

Have a good day.

Comment 5 Sergey Khvostov 2012-01-05 19:15:41 UTC

Sorry for coping message, I had a confuse with submitions. (

Comment 6 Harald Hoyer 2012-01-06 13:24:32 UTC

(In reply to comment #4)
> Hello.
> 
> Thanks for your comment regarding "--preload" key and dracut. 
> I'm talk not about dracut, but for mkinitrd.
> 
> Regarding bug: no metter with wich keys we're running mkinitrd script, in all
> cases we get error: "/sbin/mkinitrd: line 52: read_args: command not found".
> As I said the fix of that problem is very easy, but it requaried some scripting
> skills. I'd like to see fixing of that problem in some of updates (not sure
> wich package including mkinitrd script). BTW, all updates at that time were
> installed.
> 
> In case of mkinitrd replacement, mkinitrd scipt must be EOLed or redirect to
> dracut or somewhere alse. Are you agree? ;) That's why I asking you to fix that
> problem for all Fedora users.

mkinitrd is already just a wrapper, which calls dracut.

> 
> Thanks a lot.
> 
> Have a good day.

Comment 7 Harald Hoyer 2012-01-23 10:29:09 UTC

fixed "mkinitrd"

Comment 8 Sergey Khvostov 2012-01-23 21:59:33 UTC

(In reply to comment #7)
> fixed "mkinitrd"

Thank you!

Hava a nice day.