Bug 771123
| Summary: | Review Request: fex - Field split/extraction like cut/awk | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mark McKinstry <mmckinst> |
| Component: | Package Review | Assignee: | Mattia Verga <mattia.verga> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mattia.verga, notting, package-review |
| Target Milestone: | --- | Flags: | mattia.verga:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | fex-1.20100416.2814-7.el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-01-23 21:55:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Mark McKinstry
2012-01-01 18:16:04 UTC
I'm going to review this in the next few days (maybe tomorrow). - rpmlint checks return: SPECS/fex.spec: W: invalid-url Source0: http://semicomplete.googlecode.com/files/fex-1.20100416.2814.tar.gz HTTP Error 404: Not Found fex.x86_64: W: spelling-error Summary(en_US) awk -> awl, aw, wk fex.x86_64: W: spelling-error %description -l en_US tokenizeing -> betokening fex.x86_64: W: no-manual-page-for-binary fex fex.src: W: spelling-error Summary(en_US) awk -> awl, aw, wk fex.src: W: spelling-error %description -l en_US tokenizeing -> betokening fex.src: W: invalid-url Source0: http://semicomplete.googlecode.com/files/fex-1.20100416.2814.tar.gz HTTP Error 404: Not Found 3 packages and 1 specfiles checked; 0 errors, 7 warnings. URL is valid (not sure why it says different) and all other warnings can be ignored except the spelling error in %description. - naming guidelines and .spec file name: OK + packaging guidelines: SEE NOTE 1 - license: OK (BSD), in %doc - spec file legible, in am. english: OK - source matches upstream - package compiles on rawhide (i686/x86_64): OK - Build Requires: OK - no locales - no libraries - not relocatable - no directories created - no duplicate files - file permissions: OK + macros: SEE NOTE 1 - code/content: OK - no need for -docs - nothing in %doc affects runtime - no headers / no need for -devel - no GUI and no .desktop - ownership: OK - filenames: OK MUST FIX: -------------- 1: The BuildRoot tag is required only for EPEL. If you think to build this package also for EPEL you must add the %clean section. See http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag 2: Trivial: fix spelling in %description Mattia, Thank you for the review. I have: 1. Added a %clean section since I do plan on putting this in EPEL too. 2. Fixed the spelling issue. "tokenizeing" is now spelled "tokenizing". rpmlint is still unhappy with the word but tokenizing is commonly used including the wikipedia article on lexical analysis. 3. Added a Group to the spec file. It wasn't in the original spec and it looks like rpmlint doesn't check for it. Updated spec and src.rpm: http://mmckinst.fedorapeople.org/packages/fex/fex.spec http://mmckinst.fedorapeople.org/packages/fex/fex-1.20100416.2814-2.fc16.src.rpm All issues are fixed, looks good now: APPROVED. New Package SCM Request ======================= Package Name: fex Short Description: Field split/extraction like cut/awk Owners: mmckinst Branches: f15 f16 el4 el5 el6 InitialCC: Git done (by process-git-requests). fex-1.20100416.2814-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/fex-1.20100416.2814-2.el5 fex-1.20100416.2814-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/fex-1.20100416.2814-2.fc16 fex-1.20100416.2814-2.el4 has been submitted as an update for Fedora EPEL 4. https://admin.fedoraproject.org/updates/fex-1.20100416.2814-2.el4 fex-1.20100416.2814-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/fex-1.20100416.2814-2.fc15 fex-1.20100416.2814-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/fex-1.20100416.2814-2.el6 Package fex-1.20100416.2814-2.el4: * should fix your issue, * was pushed to the Fedora EPEL 4 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing fex-1.20100416.2814-2.el4' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2012-0095/fex-1.20100416.2814-2.el4 then log in and leave karma (feedback). fex-1.20100416.2814-2.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. fex-1.20100416.2814-2.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. fex-1.20100416.2814-2.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report. fex-1.20100416.2814-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. fex-1.20100416.2814-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: fex New Branches: epel7 Owners: mmckinst Git done (by process-git-requests). fex-1.20100416.2814-7.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/fex-1.20100416.2814-7.el7 fex-1.20100416.2814-7.el7 has been pushed to the Fedora EPEL 7 stable repository. |