Bug 771171

Two small notes:

During build:

+ pushd tests
~/rpmbuild/BUILD/django-tastypie-0.9.11/tests ~/rpmbuild/BUILD/django-tastypie-0.9.11
+ export PYTHONPATH=/usr/lib/python2.7/site-packages
+ PYTHONPATH=/usr/lib/python2.7/site-packages
+ ./run_all_tests.sh
** Core **
Error: No module named oauth_provider


** Basic **

2. rpmlint -i reports
./django-tastypie.spec:18: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 18)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

django-tastypie-doc.noarch: W: hidden-file-or-dir /usr/share/doc/django-tastypie-0.9.11/html/.buildinfo
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.


Those are small issues, which can be easily fixed.

Package Review
==============

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated



==== Generic ====
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported architecture.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
     Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST License file installed when any subpackage combination is installed.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
     names).
[x]: MUST Package meets the Packaging Guidelines.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generates any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.

rpmlint django-tastypie-0.9.11-1.fc17.src.rpm

django-tastypie.src: W: spelling-error Summary(en_US) webservice -> web service, web-service, service
django-tastypie.src: W: spelling-error %description -l en_US webservice -> web service, web-service, service
django-tastypie.src: W: spelling-error %description -l en_US customizable -> customization
django-tastypie.src: W: strange-permission django-tastypie.spec 0666L
django-tastypie.src:18: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 18)
django-tastypie.src: W: invalid-url Source1: django-tastypie-tests.tgz
1 packages and 0 specfiles checked; 0 errors, 6 warnings.


rpmlint django-tastypie-0.9.11-1.fc17.noarch.rpm

django-tastypie.noarch: W: spelling-error Summary(en_US) webservice -> web service, web-service, service
django-tastypie.noarch: W: spelling-error %description -l en_US webservice -> web service, web-service, service
django-tastypie.noarch: W: spelling-error %description -l en_US customizable -> customization
1 packages and 0 specfiles checked; 0 errors, 3 warnings.


rpmlint django-tastypie-doc-0.9.11-1.fc17.noarch.rpm

django-tastypie-doc.noarch: W: hidden-file-or-dir /usr/share/doc/django-tastypie-0.9.11/html/.buildinfo
1 packages and 0 specfiles checked; 0 errors, 1 warnings.


[!]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
/home/mrunge/771171/django-tastypie-0.9.11.tar.gz :
  MD5SUM this package     : 711b29265917405c226f4594782e7e9b
  MD5SUM upstream package : 711b29265917405c226f4594782e7e9b
django-tastypie-tests.tgz :
  MD5SUM this package     : 0e7372f4994b39d7951a3846696a972f
  MD5SUM upstream package : upstream source not found

[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
     /usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Package does not include license text files separate from
     upstream.
[x]: SHOULD SourceX is a working URL.
[x]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
     architectures.
[x]: SHOULD %check is present and all tests pass.
[-]: SHOULD Packages should try to preserve timestamps of original installed
     files.
[x]: SHOULD Spec use %global instead of %define.

Issues:
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf is only needed if supporting EPEL5
[!]: MUST Rpmlint output is silent.

rpmlint django-tastypie-0.9.11-1.fc17.src.rpm

django-tastypie.src: W: spelling-error Summary(en_US) webservice -> web service, web-service, service
django-tastypie.src: W: spelling-error %description -l en_US webservice -> web service, web-service, service
django-tastypie.src: W: spelling-error %description -l en_US customizable -> customization
django-tastypie.src: W: strange-permission django-tastypie.spec 0666L
django-tastypie.src:18: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 18)
django-tastypie.src: W: invalid-url Source1: django-tastypie-tests.tgz
1 packages and 0 specfiles checked; 0 errors, 6 warnings.


rpmlint django-tastypie-0.9.11-1.fc17.noarch.rpm

django-tastypie.noarch: W: spelling-error Summary(en_US) webservice -> web service, web-service, service
django-tastypie.noarch: W: spelling-error %description -l en_US webservice -> web service, web-service, service
django-tastypie.noarch: W: spelling-error %description -l en_US customizable -> customization
1 packages and 0 specfiles checked; 0 errors, 3 warnings.


rpmlint django-tastypie-doc-0.9.11-1.fc17.noarch.rpm

django-tastypie-doc.noarch: W: hidden-file-or-dir /usr/share/doc/django-tastypie-0.9.11/html/.buildinfo
1 packages and 0 specfiles checked; 0 errors, 1 warnings.


[!]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
/home/mrunge/771171/django-tastypie-0.9.11.tar.gz :
  MD5SUM this package     : 711b29265917405c226f4594782e7e9b
  MD5SUM upstream package : 711b29265917405c226f4594782e7e9b
django-tastypie-tests.tgz :
  MD5SUM this package     : 0e7372f4994b39d7951a3846696a972f
  MD5SUM upstream package : upstream source not found



Notes: 

You should correct the permission of spec file and use spaces or tabs consistently through the spec. Spelling errors are false positives.

Thanks for your review!

- I corrected the permissions and tabs/spaces.
- As for the test error "Error: No module named oauth_provider", this would need django-oauth-plus (see [1]), which is not yet in Fedora (and some of its dependencies aren't there too, if I recall it correctly), so I would leave it this way for the time being. As soon as django-oauth-plus gets into Rawhide (if I manage to get some time, I will package it), I will rebuild with all the tests. Is this a blocker for you?
- The upstream source for the tests doesn't in fact exist - you have to download them separately from the Github, as they are not included in the package downloaded from pypy. I believe that running tests is important and this is probably the best way to get them.

These are the files with your comments incorporated:
SPEC: http://bkabrda.fedorapeople.org/pkgs/django-tastypie/django-tastypie.spec
SRPM: http://bkabrda.fedorapeople.org/pkgs/django-tastypie/django-tastypie-0.9.11-2.fc16.src.rpm
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3624230

[1] https://github.com/toastdriven/django-tastypie/issues/323

Great,



APPROVED

Thanks again, Matthias.



New Package SCM Request
=======================
Package Name: django-tastypie
Short Description: Tastypie is an webservice API framework for Django
Owners: bkabrda
Branches:
InitialCC:

Git done (by process-git-requests).

Package Change Request
======================
Package Name: django-tastypie
New Branches: f16 el6
Owners: bkabrda cquad

Git done (by process-git-requests).

django-tastypie-0.9.11-2.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/django-tastypie-0.9.11-2.fc16

django-tastypie-0.9.11-2.fc16 has been pushed to the Fedora 16 stable repository.