Bug 771318

Sorry for wrong links (again ;-)

Spec URL: http://omicron.mifo.sk/rubygem-showoff.spec
SRPM URL: http://omicron.mifo.sk/rubygem-showoff-0.7.0-2.fc14.src.rpm

Revision -3:

Spec URL: http://omicron.mifo.sk/rubygem-showoff.spec
SRPM URL: http://omicron.mifo.sk/rubygem-showoff-0.7.0-3.fc14.src.rpm

* Mon Jan 03 2012 Michal Fojtik <mfojtik> - 0.7.0-3

- Removed rspec dependency
- Fixed licenses for some javascript files
- Added RMagick dependency for handling image resizing

Revision -4:

Spec URL: http://omicron.mifo.sk/showoff.spec
SRPM URL: http://omicron.mifo.sk/showoff-0.7.0-4.fc14.src.rpm

* Mon Jan 03 2012 Michal Fojtik <mfojtik> - 0.7.0-4

- Switched to application package type instead of gem

Revision -5:

Spec URL: http://omicron.mifo.sk/showoff.spec
SRPM URL: http://omicron.mifo.sk/showoff-0.7.0-5.fc14.src.rpm

* Mon Jan 03 2012 Michal Fojtik <mfojtik> - 0.7.0-5
- Changed package group to Applications/Publishing

* Name alright
* Versioning correct
* Source file matches upstream
* SPEC file clean and legible
* Builds fine in mock

1.) Require list not correct

Requires:       ruby(abi) = 1.8

Please drop this -- you don't install modules into 1.8 release specific location and thus don't need to require a particular ABI.

2.) Licensing is suspicious

You need to clarify this:
# Unknown license (same as JQuery?)
%{app_root}/public/js/jquery.batchImageLoad.js
%{app_root}/public/js/jquery.uuid.js

3.) Rpmlint not happy

showoff.src:60: E: files-attr-not-set
A file or a directory entry in a %files section does not have attributes set
which may result in security issues in the resulting binary package depending
on the system where the package is built.  Add default attributes using
%defattr before it in the %files section, or use per line %attr's.

showoff.src: W: no-%clean-section
The spec file doesn't contain a %clean section to remove the files installed
by the %install section.

showoff.src:11: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 11)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.