Bug 771404

Summary:	Tablet PC: Wacom driver registers button press without stylus' touching the screen
Product:	Red Hat Enterprise Linux 6	Reporter:	Andrew Lofthouse <loftyhauser>
Component:	xorg-x11-drv-wacom	Assignee:	Peter Hutterer <peter.hutterer>
Status:	CLOSED NOTABUG	QA Contact:	Desktop QE <desktop-qa-list>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	6.2	CC:	tpelka
Target Milestone:	rc
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-04-29 03:47:14 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	842499, 960058

Description Andrew Lofthouse 2012-01-03 16:06:11 UTC

Description of problem: When using a Fujitsu T5010 Tablet PC, the stylus is handled by the xorg-x11-drv-wacom driver. A right-click should be registered when the stylus is tapped on the screen while pushing the stylus button. However, with the current driver, the right-click is registered as soon as the stylus button is pressed, while the stylus is within proximity of the screen (and does not require that the screen be tapped).

Version-Release number of selected component (if applicable): 0.10.5-14

How reproducible: Always

Steps to Reproduce:
1. install RHEL 6.2 on Fujitsu T5010
2. log into desktop
3. attempt to right-click on desktop by tapping screen while pushing stylus button

Actual results:
Right-click is registered as soon as stylus is in proximity of the screen, but without touching the screen

Expected results:
Right-click is registered when the stylus touches the screen and not before.

Additional info:
This is an extension of Bug 561835 (xorg-x11-drv-wacom-0.10.4 with Fedora 12 -- see https://bugzilla.redhat.com/show_bug.cgi?id=561835#c24). With RHEL 6.1, I was able to work around this bug by re-building the xorg-x11-drv-wacom-0.10.8-2 RPM from Fedora. However, this work-around no longer works with the ABI changes in 6.2 (since the 0.10.8-2 package no longer compiles).

Rather than mess with the ABI changes, I've tried to track down the actual patches that fix the problem. I've tracked down the actual fix to a couple of git commits (from xf86-input-wacom). These commits are:

b3143b5 Centralize TPCbutton/Touch/Gesture initialization
cda653b Change WacomModel->name to WacomModel->tablet_type

I've noticed that the git repo also contains a rhel6-branch that seems to track with the 6.1 version (0.10.5-9). From that branch, I've tried to cherry-pick the two commits listed above, along with the following, prerequisite, commit:

df7f165 Add tablet_type to WacomModel

Unfortunately, commit b3143b5 does not apply cleanly (specifically for src/wcmUSB.c), even after applying commit df7f165. Apparantly, other pre-requisite patches are required to resolve the conflict.

(Note: A wacom.fdi file is present in /etc/hal/fdi/policy as suggested in https://bugzilla.redhat.com/show_bug.cgi?id=561835#c14.)

Comment 2 Andrew Lofthouse 2012-01-03 16:49:26 UTC

Nevermind,

Option "TPCButton" "on"

in /etc/X11/xorg.conf.d/50-wacom.conf seems to work.

Comment 3 Peter Hutterer 2012-01-05 23:47:01 UTC

Can you attach the evtest log for this device? maybe we can improve the auto-detection.

Comment 5 RHEL Program Management 2012-05-03 05:18:40 UTC

Since RHEL 6.3 External Beta has begun, and this bug remains
unresolved, it has been rejected as it is not proposed as
exception or blocker.

Red Hat invites you to ask your support representative to
propose this request, if appropriate and relevant, in the
next release of Red Hat Enterprise Linux.

Comment 6 Peter Hutterer 2013-04-29 03:19:38 UTC

Andrew: we've had two wacom rebases, one for 6.3, one for 6.4. Can you please verify whether this bug is still present or whether it was fixed in the rebases? Thanks.

Comment 7 Andrew Lofthouse 2013-04-29 03:25:51 UTC

Sorry, I no longer have that specific machine (or another Tablet PC I can test with)...

Comment 8 Peter Hutterer 2013-04-29 03:47:14 UTC

Thanks Andrew.

I'm closing this bug as NOTABUG (technically worksforme, but this isn't available on RHEL bugs).

Reason for closing:
Bug reported against 0.10.5-14. RHEL 6.3 and 6.4 have seen wacom rebases to 0.13.0 and 0.16.1, respectively. The reporter found this bug fixed in xorg-x11-drv-wacom-0.10.8-2 (Fedora 13). This changeset is included in 0.13.0 and 0.16.1 and the behaviour of the tablet PC is as documented.