| Summary: | Review Request: libcxgb4 - Chelsio T4 iWARP HCA Userspace Driver | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Doug Ledford <dledford> |
| Component: | Package Review | Assignee: | Albert Strasheim <fullung> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | fenlason, fullung, notting, package-review |
| Target Milestone: | --- | Flags: | fenlason:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | http://people.redhat.com/dledford/Package%20Review/ | ||
| Whiteboard: | |||
| Fixed In Version: | libcxgb4-1.2.0-1.fc16 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-02-01 19:23:43 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Doug Ledford
2012-01-03 21:21:38 UTC
$ rpmlint libcxgb4*
libcxgb4.x86_64: W: spelling-error Summary(en_US) Chelsio -> Chelsea
libcxgb4.x86_64: W: spelling-error Summary(en_US) iWARP -> i Warp, warp, antiwar
libcxgb4.x86_64: W: spelling-error %description -l en_US Userspace -> User space, User-space, Users pace
libcxgb4.x86_64: W: spelling-error %description -l en_US libibverbs -> verbalizes
libcxgb4.x86_64: W: spelling-error %description -l en_US iWARP -> i Warp, warp, antiwar
libcxgb4.x86_64: W: obsolete-not-provided libcxgb4-devel
libcxgb4.x86_64: W: non-conffile-in-etc /etc/modprobe.d/libcxgb4.conf
libcxgb4.x86_64: W: non-conffile-in-etc /etc/libibverbs.d/cxgb4.driver
libcxgb4.spec:13: W: unversioned-explicit-obsoletes %{name}-devel
libcxgb4.spec:15: W: unversioned-explicit-provides libibverbs-driver.%{_arch}
libcxgb4-static.x86_64: W: no-documentation
2 packages and 1 specfiles checked; 0 errors, 11 warnings.
I don't have this hardware, so I can't test further unfortunately.
I noticed that libmlx4-static provides libmlx4-devel-static. What's up with that? Should libcxgb4-static do the same?
libmlx4 provides libmlx4-devel-static because early versions of the package provided that. We switched the package naming over to the more standard compliant base base-devel base-static long ago and the old provides is in libmlx4 to keep any software that didn't get updated from breaking. Libcxgb4 has no such broken history and need not provide -devel-static as a package. Albert, are you good with signing off on this package at this point? Looks good to me. New Package SCM Request ======================= Package Name: libcxgb4 Short Description: Driver for Chelsio T4 hardware Owners: dledford Branches: f15 f16 InitialCC: Git done (by process-git-requests). libcxgb4-1.2.0-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/libcxgb4-1.2.0-1.fc15 libcxgb4-1.2.0-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/libcxgb4-1.2.0-1.fc16 libcxgb4-1.2.0-1.fc16 has been pushed to the Fedora 16 testing repository. libcxgb4-1.2.0-1.fc15 has been pushed to the Fedora 15 stable repository. libcxgb4-1.2.0-1.fc16 has been pushed to the Fedora 16 stable repository. |