Bug 771781

Summary: Numerous Use of qw(...) as parentheses is deprecated messages
Product: [Fedora] Fedora Reporter: Frank Crawford <frank>
Component: perl-IPTables-ChainMgrAssignee: Miloslav Trmač <mitr>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 16CC: frank, mitr, perl-devel
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: perl-IPTables-ChainMgr-0.9-9.fc16 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-01-19 21:59:40 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Untested! patch none

Description Frank Crawford 2012-01-04 22:56:51 UTC
Description of problem:
Due to a change in perl syntax for Perl 5.14 and onwards, the use of qw(...) in
specific contexts is now disallowed.  This generates lots of messages of the
form:
Use of qw(...) as parentheses is deprecated at /usr/share/perl5/vendor_perl/IPTables/ChainMgr.pm line 158.

Version-Release number of selected component (if applicable):
perl-IPTables-ChainMgr-0.9-8.fc16.noarch
perl-5.14.2-191.fc16.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Found from "psad -S" but possible from any use of routine.
2.
3.
  
Actual results:
Numerous messages about deprecated feature.

Expected results:
No deprecated messages

Additional info:
Reading some of the perl list this only occurs in statements of the form:
for my $var qw(...) { ... }
and is fixed by the addition of "()", i.e.
for my $var (qw(...)) { ... }

Comment 1 Miloslav Trmač 2012-01-06 12:53:18 UTC
Thanks for your report.

To reproduce: unpack source code and
> cd t; perl IPTables-ChainMgr.t

Comment 2 Miloslav Trmač 2012-01-06 14:32:48 UTC
Created attachment 551153 [details]
Untested! patch

Comment 3 Frank Crawford 2012-01-07 00:29:45 UTC
I've applied the patch and tested it lightly and it fixes the messages from ChainMgr.pm

Thanks for the fast work.

Comment 4 Miloslav Trmač 2012-01-10 21:46:24 UTC
Thanks for the testing.

I have finally managed to check that this doesn't break the fwknop testsuite, and sent it upstream.  F16 package update and rawhide build will follow shortly.

Comment 5 Fedora Update System 2012-01-11 11:39:03 UTC
perl-IPTables-ChainMgr-0.9-9.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/perl-IPTables-ChainMgr-0.9-9.fc16

Comment 6 Fedora Update System 2012-01-11 20:54:41 UTC
Package perl-IPTables-ChainMgr-0.9-9.fc16:
* should fix your issue,
* was pushed to the Fedora 16 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing perl-IPTables-ChainMgr-0.9-9.fc16'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-0394/perl-IPTables-ChainMgr-0.9-9.fc16
then log in and leave karma (feedback).

Comment 7 Fedora Update System 2012-01-19 21:59:40 UTC
perl-IPTables-ChainMgr-0.9-9.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.