Bug 771842

Summary:	Review Request: navilu-fonts - Free Kannada Opentype sans-serif font
Product:	[Fedora] Fedora	Reporter:	Pravin Satpute <psatpute>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	16	CC:	i18n-bugs, notting, package-review, panemade, svenkate
Target Milestone:	---	Keywords:	i18n
Target Release:	---	Flags:	panemade: fedora-review+ gwync: fedora-cvs+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-01-10 07:13:11 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Pravin Satpute 2012-01-05 08:14:30 UTC

SPEC Url: http://pravins.fedorapeople.org/navilu-fonts.spec
SRPM Url: http://pravins.fedorapeople.org/navilu-fonts-1.1-1.fc16.src.rpm

Scratch build : http://koji.fedoraproject.org/koji/taskinfo?taskID=3621205

Comment 1 Parag AN(पराग) 2012-01-06 08:30:35 UTC

Review:

+ koji scratch build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3621205

+ rpmlint on rpms gave
 navilu-fonts.noarch: W: spelling-error Summary(en_US) opentype -> open type, open-type, phenotype
navilu-fonts.noarch: W: spelling-error %description -l en_US opentype -> open type, open-type, phenotype
navilu-fonts.src: W: spelling-error Summary(en_US) opentype -> open type, open-type, phenotype
navilu-fonts.src: W: spelling-error %description -l en_US opentype -> open type, open-type, phenotype
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

+ source verified with upstream as (sha1sum)
eb71807bdfcc479ad5eac07d18da82100a2fd349  navilu-1.1.tar.gz
eb71807bdfcc479ad5eac07d18da82100a2fd349  ../SOURCES/navilu-1.1.tar.gz

+ follows fonts packaging guidelines


Suggestions
1) you should drop the versioned dependency. Change
BuildRequires: fontforge >= 20080429
to
BuildRequires: fontforge

2)you don't need to clean buildroot now. remove following from spec
BuildRequires: fontforge >= 20080429


APPROVED.

Comment 2 Pravin Satpute 2012-01-09 07:31:32 UTC

Thank you Parag for review, i will do the suggested changes during git import.

New Package SCM Request
=======================
Package Name: navilu-fonts
Short Description: Free Kannada Opentype sans-serif font
Owners: pravins
Branches: f16
InitialCC: i18n-team

Comment 3 Gwyn Ciesla 2012-01-09 13:08:23 UTC

Git done (by process-git-requests).

Comment 4 Pravin Satpute 2012-01-10 07:13:11 UTC

Thanks Jon for Git process. done built for rawhide and F16