Bug 771925

Description of problem:

glusterd which takes care of issuing SIGUSR1 to the brick processes for taking the statedump will write the options mentioned by the user (given through cli) about what all information has to be dumped to the statedump file. 

This is the piece of code from glusterd_brick_statedump function of glusterd which does the above functionality.

snprintf (dumpoptions_path, sizeof (dumpoptions_path),
                  "/tmp/glusterdump.%d.options", pid);
	glusterd_set_dump_options (dumpoptions_path, options, option_cnt);

        
        gf_log ("", GF_LOG_INFO, "Performing statedump on brick with pid %d",
		pid);

        kill (pid, SIGUSR1);

        sleep (1);
        unlink (dumpoptions_path);

        ret = 0;
out:
        if (pidfile)
                fclose (pidfile);
        return ret;


It can be seen from the code that, glusterd issues the SIGUSR1 signal to the brick process for taking statedump. But after that it sleeps for 1 second and then removes the file which contains the options provided by user.

The glusterfs process which receives the SIGUSR1 signal will look into the /tmp/glusterdump.%s.options file and dumps the information that have been mentioned in that file.

Instead of glusterd assuming the statedump would have been taken in 1 second and unlinking it would be good if the glusterfs process itself deletes the file after dumping the the information.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info: