Bug 772074

Summary:	ID default in Web Designer is not good
Product:	[JBoss] JBoss Enterprise BRMS Platform 5	Reporter:	Jeff DeLong <jdelong>
Component:	jBPM 5	Assignee:	Kris Verlaenen <kverlaen>
Status:	VERIFIED ---	QA Contact:	Lukáš Petrovický <lpetrovi>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	BRMS 5.3.0.GA
Target Milestone:	---
Target Release:	BRMS 5.3.0.GA
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Jeff DeLong 2012-01-05 21:27:28 UTC

Description of problem:

When I create a new process in the Web Designer I notice the ID defaults to com.sample.bpmn2. Is this really a good default? It would probably never be what the user wanted, and by defaulting to the same value, the user could create multiple processes with the same ID.

Alternatives would be to:

- leave it blank but make sure the process validator catches it and notifies the user when they validate or attempt to save

- concatenation of the packageName and processName. This is probably a "best practice" since it would help ensure uniqueness, while at the same time use what the processName the user has already selected (most users don't realize the name and the ID can be different and that the ID is used to start the process).


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 2 Kris Verlaenen 2012-01-26 13:03:41 UTC

Tiho, since the package name and the process name are available when creating a process in guvnor, using packagename.processname probably is a better default.  Could you change the id generator to use this if possible?

Comment 4 Tihomir Surdilovic 2012-01-27 16:16:23 UTC

Done - please retest with latest war on people.redhat.com/tsurdilo/designer/master

Comment 5 Jeff DeLong 2012-01-28 03:38:59 UTC

I verified with the latest Designer. ID is set to package.name.processname

Thanks.

Comment 6 Ryan Zhang 2012-02-15 09:11:34 UTC

Please verify the issue on 5.3 ER4.

Comment 7 Zuzana Krejčová 2012-02-22 11:09:57 UTC

It now defaults to com.sample.bpmm2 (yes, bpmm2).

Comment 8 Tihomir Surdilovic 2012-02-22 11:26:39 UTC

You uploaded that process after creating it in eclipse, didn't you? :) 
Should test with a process created in designer from scratch.

Comment 9 Zuzana Krejčová 2012-02-22 11:54:33 UTC

(In reply to comment #8)
> You uploaded that process after creating it in eclipse, didn't you? :) 
> Should test with a process created in designer from scratch.

No, it really is made from scratch in the designer.
I go to Guvnor, create a new bpmn2 process - which opens the designer. 
Then I add a start event - to have something to click on due to bug https://bugzilla.redhat.com/show_bug.cgi?id=768198 
and click on the start event, 
click somewhere else on the canvas 
and click the right panel. 
There I find the generated, default id which is com.sample.bpmm2.

Comment 10 Tihomir Surdilovic 2012-02-22 12:12:25 UTC

The issue with process properties not showing up initially and having to click on a node and then back on the canvas has been fixed. I don't know if we are testing with the latest or not :( 
Just fixed a bug in jBPM (code used by the eclipse editor that had this issue: https://github.com/droolsjbpm/jbpm/commit/d8e21d97b0aa54d7aaa784573052d2c53ac19214. Designer is not causing this issue as it does not have a typo (bpmm2). That's why I assumed you have created the process there. 
Otherwise you have a package com.sample and you have the type on your asset name (called it bpmm2) .. can't think of anything else.

Comment 11 Zuzana Krejčová 2012-02-22 12:43:27 UTC

I am testing with what we get in BRMS 5.3.0 ER4. (I was told it's supposed to be the latest version - from this morning.)
The new process is in the package "defaultPackage" and is named "test". The id defaults to "com.sample.bpmm2".

Comment 12 Tihomir Surdilovic 2012-02-22 13:05:07 UTC

Really sorry but I cannot reproduce. Any way I could get a hold of the war file you are using for testing?

Comment 13 Zuzana Krejčová 2012-02-29 12:22:30 UTC

It seems we got an older build without the new designer. I tried again today with a newer build, it is fixed. Thanks for the good work, the new designer looks quite good.