| Summary: | Review Request: srptools - utilities for mounting SRP shared resources | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Doug Ledford <dledford> |
| Component: | Package Review | Assignee: | Albert Strasheim <fullung> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | fenlason, fullung, notting, package-review |
| Target Milestone: | --- | Flags: | fenlason:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | http://people.redhat.com/dledford/Package%20Review/ | ||
| Whiteboard: | |||
| Fixed In Version: | srptools-0.0.4-11.fc16 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-02-01 19:24:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Doug Ledford
2012-01-06 16:04:02 UTC
$ rpmlint srptools.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint srptools-0.0.4-11.fc15.x86_64.rpm
srptools.x86_64: W: spelling-error %description -l en_US ib -> bi, ob, iv
srptools.x86_64: W: spelling-error %description -l en_US srp -> rps, sip, sap
srptools.x86_64: W: obsolete-not-provided openib-srptools
srptools.x86_64: W: no-manual-page-for-binary run_srp_daemon
srptools.x86_64: W: no-manual-page-for-binary srp_daemon.sh
srptools.x86_64: E: init-script-without-chkconfig-postin /etc/rc.d/init.d/srpd
srptools.x86_64: E: init-script-without-chkconfig-preun /etc/rc.d/init.d/srpd
srptools.x86_64: W: missing-lsb-keyword Required-Start in /etc/rc.d/init.d/srpd
srptools.x86_64: W: incoherent-init-script-name srpd ('srptools', 'srptoolsd')
1 packages and 0 specfiles checked; 2 errors, 7 warnings.
/etc/rc.d/init.d/srpd should probably converted to a systemd .service file?
Yes and no. I plan to add this package to f15/f16/rawhide. The rest of the IB stack in both f15 and f16 are still SysV init based and I don't want to mix SysV and systemd unit files. So, the plan is to put this package as it is in, then update the rdma, opensm, and this package at the same time to systemd units in rawhide. New Package SCM Request ======================= Package Name: srptools Short Description: Tools to mount SRP devices across RDMA networks Owners: dledford Branches: f15 f16 InitialCC: Git done (by process-git-requests). srptools-0.0.4-11.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/srptools-0.0.4-11.fc16 srptools-0.0.4-11.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/srptools-0.0.4-11.fc15 srptools-0.0.4-11.fc16 has been pushed to the Fedora 16 testing repository. srptools-0.0.4-11.fc15 has been pushed to the Fedora 15 stable repository. srptools-0.0.4-11.fc16 has been pushed to the Fedora 16 stable repository. |