Bug 772298

Summary: Poorly named PDF files
Product: Red Hat Enterprise Linux 6 Reporter: masterroog
Component: publicanAssignee: Jeff Fearn 🐞 <jfearn>
Status: CLOSED NOTABUG QA Contact: ecs-bugs
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.4CC: syeghiay
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-06-30 02:12:42 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Patch for the Builder perl module to check string length when forming pdf name none

Description masterroog 2012-01-06 17:50:48 UTC
Created attachment 551214 [details]
Patch for the Builder perl module to check string length when forming pdf name

Description of problem:  

Components of a pdf filename have dashes between them regardless of the string content.  PDF files are always named in the format filename is in the form   product-version-docname-lang.pdf.  If a version number is not provided, it will form a filename with "--"


Steps to Reproduce:
1. Publish a docbook book with a blank version number
  
Actual results:

filename is in the form   product--docname-lang.pdf


Expected results:

filename is in the form   product-docname-lang.pdf


I propose wrapping a conditional around the version number that checks the length of the version variable, and only adding a dash if it is greater than zero.

Comment 3 Suzanne Logcher 2012-02-14 23:27:09 UTC
This request was evaluated by Red Hat Product Management for
inclusion in the current release of Red Hat Enterprise Linux.
Because the affected component is not scheduled to be updated
in the current release, Red Hat is unfortunately unable to
address this request at this time. Red Hat invites you to
ask your support representative to propose this request, if
appropriate and relevant, in the next release of Red Hat
Enterprise Linux. If you would like it considered as an
exception in the current release, please ask your support
representative.

Comment 4 RHEL Program Management 2012-07-10 08:33:26 UTC
This request was not resolved in time for the current release.
Red Hat invites you to ask your support representative to
propose this request, if still desired, for consideration in
the next release of Red Hat Enterprise Linux.

Comment 5 RHEL Program Management 2012-07-11 01:57:05 UTC
This request was erroneously removed from consideration in Red Hat Enterprise Linux 6.4, which is currently under development.  This request will be evaluated for inclusion in Red Hat Enterprise Linux 6.4.

Comment 6 RHEL Program Management 2012-09-07 05:35:35 UTC
This request was evaluated by Red Hat Product Management for
inclusion in the current release of Red Hat Enterprise Linux.
Because the affected component is not scheduled to be updated
in the current release, Red Hat is unable to address this
request at this time.

Red Hat invites you to ask your support representative to
propose this request, if appropriate, in the next release of
Red Hat Enterprise Linux.

Comment 7 Martin Prpič 2012-10-15 09:10:46 UTC
This is somewhat fixed in publican-3.0-0.fc17.t216.noarch since the version number was made mandatory. If you don't specify one, you get the following error when building:

Invalid format for version. Value (EMPTY) does not conform to constraint (^[0-9]) at /usr/bin/publican line 692

Please re-test and close if this issue is resolved on your system.

Cheers,
Martin

Comment 8 Jeff Fearn 🐞 2014-06-30 02:12:42 UTC
Fixed upstream, but the documentation process has nothing to do with the RHEL6 product.