| Summary: | Proftpd packaging and configuration has some vroot-related issues | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Philip Prindeville <philipp> | ||||
| Component: | proftpd | Assignee: | Matthias Saou <matthias> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 16 | CC: | matthias, paul, philipp | ||||
| Target Milestone: | --- | Keywords: | EasyFix | ||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | proftpd-1.3.4a-3.fc16 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2012-01-24 20:00:05 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
Please take a look at the new Rawhide package (1.3.4a-2) and see what you think. * Made mod_vroot a DSO and loaded it by default * Dropped VRootAlias of /etc/security/pam_env.conf as it's not needed (simply using mod_vroot fixes the problem that was addressing) * Added BanMessage * Added proftpd-devel package for building third-party modules I didn't change the proftpd.service file because I don't think there's anything wrong with it (In reply to comment #1) > Please take a look at the new Rawhide package (1.3.4a-2) and see what you > think. > > * Made mod_vroot a DSO and loaded it by default > > * Dropped VRootAlias of /etc/security/pam_env.conf as it's not needed (simply > using mod_vroot fixes the problem that was addressing) > > * Added BanMessage > > * Added proftpd-devel package for building third-party modules > > I didn't change the proftpd.service file because I don't think there's anything > wrong with it My only comment is this: the LoadModule and the <IfModule ...> stuff tend to be separate so that configuring and simply enabling are distinct. I would stick with that convention for consistency. Otherwise, looks good. Ship it! Another change I plan to do first is to split off a "utils" subpackage with the perl scripts in it (like the upstream package) so that the main package doesn't require perl. Just a bit busy at the moment. proftpd-1.3.4a-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/proftpd-1.3.4a-3.fc16 Package proftpd-1.3.4a-3.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing proftpd-1.3.4a-3.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-0595/proftpd-1.3.4a-3.fc16 then log in and leave karma (feedback). proftpd-1.3.4a-3.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 551293 [details] Make vroot optional. Description of problem: First, forcing mod_vroot on is excessive. Let's make it a loadable module. Second, change the config to only apply if it's been loaded. Third, remove the spaces from the systemd service file. Fourth, add BanMessage to mod_ban section. Version-Release number of selected component (if applicable): 1.3.4-1 How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: