Bug 772499

I reviewed this package and have some remarks about minor issues:

* rpmlint says
   python-anfft.src: W: spelling-error %description -l en_US Accummulated -> Accumulated, Accumulate, Acculturated
   python-anfft.src: W: spelling-error %description -l en_US dotfile -> dot file, dot-file, docile
Please fix the first one. I don't know what a 'dotfile' is. If you do please fix this if necessary.

! The license can be marked as GPLv3+ since the source files have the "or later" clause but this is not a blocker since there is no GPLv4 for the time being.

- During the build, I get a warning during %check:
    + python test.py
    /builddir/build/BUILD/anfft-0.1/anfft/_fftw.py:260: UserWarning: Can't load wisdom from "/builddir/.anfft"
      warn("Can't load wisdom from \"%s\"" % basedir)
But looking through the source code, this warning seems unimportant.

*   BuildRequires: numpy fftw-devel python-devel
    BuildRequires: python-devel
is too much. Instead
    BuildRequires: numpy fftw python2
is sufficient. Note that python-devel was listed twice. Also note that we specify the python version.

! rm -rf %{buildroot}
is not required in %install. Does no harm though.

! You can probably use
   libdir=build/lib
in %check (build/lib is what I have on x86_64 too).

Thanks for these remarks. Here is a corrected version:
Spec URL: http://tnorth.fedorapeople.org/python-anfft.spec
SRPM URL: http://tnorth.fedorapeople.org/python-anfft-0.1-2.fc15.src.rpm

>- During the build, I get a warning during %check:
>    + python test.py
>    /builddir/build/BUILD/anfft-0.1/anfft/_fftw.py:260: UserWarning: Can't load
>wisdom from "/builddir/.anfft"
>      warn("Can't load wisdom from \"%s\"" % basedir)
>But looking through the source code, this warning seems unimportant.

Indeed, that is fftw trying to read a file created at the first run only, specifying which method runs faster on the machine.

Hi Thibault, thank you for the update.

The Requires list is fine now, but you accidentally removed BuildRequires too. As far as I can tell, Requires and BuildRequires should be the same. Moreover they can be further simplified (sorry I missed this in the first pass). "fftw" package itself is not required, but its dependencies "fftw-libs" "fftw-libs-threads" are required. Therefore we can do

   BuildRequires:  numpy fftw-libs fftw-libs-threads python2
   Requires:       numpy fftw-libs fftw-libs-threads python2

Since this is an easy fix, I am approving the package. Please consider the above before you import.


-----------------------------------------------
This package (python-anfft) is APPROVED by oget
-----------------------------------------------

Hi Orcan, 

Thanks for your review. I haven't had much time these days, and indeed I accidentally removed the buildrequires!

I will import an updated version, corresponding to the spec:
Spec URL: http://tnorth.fedorapeople.org/python-anfft.spec

Please include an SCM request: 

https://fedoraproject.org/wiki/Package_SCM_admin_requests

Definitely not my day :(
Sorry for that.

New Package SCM Request
=======================
Package Name: python-anfft
Short Description: ANFFT is an FFT package for Python, based on FFTW
Owners: tnorth
Branches: f15 f16

Git done (by process-git-requests).

python-anfft-0.1-3.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/python-anfft-0.1-3.fc15

python-anfft-0.1-3.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/python-anfft-0.1-3.fc16

python-anfft-0.1-3.fc16 has been pushed to the Fedora 16 testing repository.

python-anfft-0.1-3.fc16 has been pushed to the Fedora 16 stable repository.

python-anfft-0.1-3.fc15 has been pushed to the Fedora 15 stable repository.