| Summary: | Review Request: perl-Marpa-XS - Language grammar parser module for Perl | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lubomir Rintel <lkundrak> | ||||
| Component: | Package Review | Assignee: | Marcela Mašláňová <mmaslano> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | dwmw2, notting, package-review | ||||
| Target Milestone: | --- | Flags: | mmaslano:
fedora-review+
gwync: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2012-02-13 18:37:17 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
|
Description
Lubomir Rintel
2012-01-08 22:54:17 UTC
Created attachment 551802 [details]
patch to spec
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires FAIL
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK
Please, review and apply changes from my specfile patch. There is missing one BR, but also provided/required nonsenses.
Thanks for packaging, I was thinking about this one.
Thank you, I've applied your package. Once the package is approved, would you mind co-maintaining it? SPEC: http://v3.sk/~lkundrak/SPECS/perl-Marpa-XS.spec SRPM: http://v3.sk/~lkundrak/SRPMS/perl-Marpa-XS-1.002000-2.el6.src.rpm (In reply to comment #3) > Thank you, I've applied your package. > Once the package is approved, would you mind co-maintaining it? > Yes, could you add all of us? mmaslano, ppisar, psabata > SPEC: http://v3.sk/~lkundrak/SPECS/perl-Marpa-XS.spec > SRPM: http://v3.sk/~lkundrak/SRPMS/perl-Marpa-XS-1.002000-2.el6.src.rpm I can't see SRPM, but because you fixed specfile, it should built now. I test it with the patch with previous version. APPROVED Thank you. New Package SCM Request ======================= Package Name: perl-Marpa-XS Short Description: Language grammar parser module for Perl Owners: mmaslano, ppisar, psabata, lkundrak Branches: f15 f16 el6 Git done (by process-git-requests). Added f17, perl-sig. Imported and built. Thanks! |