Bug 772517

Summary: libconcord has incorrect "flash_base" for Logitech Harmony 550 remote
Product: [Fedora] Fedora Reporter: Gregory S. Hoerner <ghoerner>
Component: libconcordAssignee: Adam Williamson <awilliam>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 16CC: awilliam, gustavo, silfreed
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: libconcord-0.23-9.fc15 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-01-24 19:56:53 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch file to correct "flash_base"
none
SPEC file including the "flash_base" patch. none

Description Gregory S. Hoerner 2012-01-09 01:44:53 UTC
Description:

When attempting to program a Logitech Harmony remote, the process fails with the error message:

Error while erasing flash
    (libconcord function erase_config error 6)

Traceback (most recent call last):
  File "/usr/bin/congruity", line 702, in _WorkerFunction
    self._WorkerFunctionBody()
  File "/usr/bin/congruity", line 838, in _WorkerFunctionBody
    py_object((self._DgUpdate, self.dg_erase))
  File "/usr/lib64/python2.7/site-packages/libconcord.py", line 97, in __call__
    raise LibConcordException(self.func_name, result)
LibConcordException: libconcord function 'erase_config' failed with error code 6 ('Error while erasing flash')


How reproducible:

Always

Steps to Reproduce:
1. Attempt to program a Logitech Harmony 550 remote.
  
Additional Info:

This bug has been identified and fixed by a Debian user as identified in the following bug:

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=594615

The source code in the Fedora source RPM still has the old [incorrect] "flash_base" in the remote_info.h file (verified).

I've created an appropriate patch to correct and attached.

Unfortunately, I was unable to build an RPM using the existing spec file. I'm not sure if I'm missing something, or if the spec file has another error, as it fails to build concordance due to the "concord" library not being found (-lconcord) during the process. This is unrelated to the patch I created, as it fails even when using the stock spec file and source (+patches) to rebuild the RPM.

Comment 1 Gregory S. Hoerner 2012-01-09 01:46:25 UTC
Created attachment 551476 [details]
Patch file to correct "flash_base"

Comment 2 Gregory S. Hoerner 2012-01-09 01:47:16 UTC
Created attachment 551477 [details]
SPEC file including the "flash_base" patch.

No version/release information was changed, just added the patch.

Comment 3 Gregory S. Hoerner 2012-01-09 18:44:35 UTC
Just tried again, there is definitely something wrong with the Makefile(s) in the tarball (or I'm just missing something in the SPEC file). I was able to successfully build "libconcord" with the patch, but I had to have the "libconcord-devel" package installed first in order to do so;

see:

/concordance-0.23/concordance/Makefile.am (Line 10)

concordance_LDFLAGS = -lconcord

You can reproduce this particular bug by removing libconcord-devel and trying to [rpm]build the libconcord package.

Comment 4 Gregory S. Hoerner 2012-01-10 01:34:29 UTC
I just tested my patched version of libconcord and was able to program my remote successfully without issue using Congruity. From what I've read (from other people applying the same changes), this fix will allow being able to program all remotes from this architecture level.

Comment 5 Adam Williamson 2012-01-17 01:55:51 UTC
Greg: I don't see the second issue - in a mock build of libconcord, you get a warning about -lconcord, but it says 'this should be fine' and the build succeeds.

I'll add the recent-ish upstream commits to remote_info.h, which fix this bug plus add some identifications for newer remotes - see http://concordance.cvs.sourceforge.net/viewvc/concordance/concordance/libconcord/remote_info.h?view=log . Thanks!



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

Comment 6 Fedora Update System 2012-01-19 19:00:09 UTC
libconcord-0.23-9.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/libconcord-0.23-9.fc15

Comment 7 Fedora Update System 2012-01-19 19:01:55 UTC
libconcord-0.23-9.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/libconcord-0.23-9.fc16

Comment 8 Fedora Update System 2012-01-21 21:48:11 UTC
Package libconcord-0.23-9.fc15:
* should fix your issue,
* was pushed to the Fedora 15 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing libconcord-0.23-9.fc15'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-0717/libconcord-0.23-9.fc15
then log in and leave karma (feedback).

Comment 9 Fedora Update System 2012-01-24 19:56:53 UTC
libconcord-0.23-9.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2012-01-24 19:57:28 UTC
libconcord-0.23-9.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.