Bug 772563

Summary: [ovirt] [vdsm] Makefile use build machine binary path and ignore Make configuration
Product: [Retired] oVirt Reporter: Haim <hateya>
Component: vdsmAssignee: Douglas Schilling Landgraf <dougsland>
Status: CLOSED NOTABUG QA Contact: yeylon <yeylon>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: abaron, acathrow, bazulay, fsimonce, iheim, srevivo, yeylon, ykaul
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-01-31 17:36:39 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Haim 2012-01-09 09:11:07 UTC
Description of problem:

example: 

- run 'make rpm' on machine where qemu-img resides in '/usr/local/bin/qemu-img'
- install vdsm rpm on Fedora host where qemu-img resides in '/usr/bin/qemu-img'
- vi /usr/share/vdsm/constants.py - EXT_QEMUIMG = '/usr/local/bin/qemu-img'
- createVolume will fail as vdsm uses the wrong PATH. 

desired behavior: 

- ignore build machine binary location, and use configuration.

Comment 1 Douglas Schilling Landgraf 2012-01-17 18:09:31 UTC
The following patch should resolve this bug:
http://gerrit.ovirt.org/#change,1114

Thanks
Douglas

Comment 2 Federico Simoncelli 2012-01-20 12:52:34 UTC
(In reply to comment #0)
> Description of problem:
> 
> example: 
> 
> - run 'make rpm' on machine where qemu-img resides in '/usr/local/bin/qemu-img'
> - install vdsm rpm on Fedora host where qemu-img resides in '/usr/bin/qemu-img'
> - vi /usr/share/vdsm/constants.py - EXT_QEMUIMG = '/usr/local/bin/qemu-img'
> - createVolume will fail as vdsm uses the wrong PATH. 
> 
> desired behavior: 
> 
> - ignore build machine binary location, and use configuration.

The build machine must be a clean environment of the target platform.
Eventually you can avoid this behavior by setting the PATH:

 $ ./autogen.sh --system | grep qemu-img
 checking for qemu-img... /usr/local/bin/qemu-img

 $ PATH=/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin \
   ./autogen.sh --system | grep qemu-img
 checking for qemu-img... /usr/bin/qemu-img

Comment 3 Douglas Schilling Landgraf 2012-01-20 18:06:55 UTC
Hi Federico,

 I totally agree with your comment but please consider my reply comments at gerrit. I will let Dan/you decides which approach to take with this BZ (NOTABUG or apply the patch).

http://gerrit.ovirt.org/#patch,sidebyside,1114,2,/COMMIT_MSG

Thanks
Douglas

Comment 4 Douglas Schilling Landgraf 2012-01-31 17:36:39 UTC
The build machine must be a clean environment of the target platform.