Bug 772777

Summary:	pre compile and normalize search filter
Product:	Red Hat Enterprise Linux 6	Reporter:	Rich Megginson <rmeggins>
Component:	389-ds-base	Assignee:	Rich Megginson <rmeggins>
Status:	CLOSED ERRATA	QA Contact:	IDM QE LIST <seceng-idm-qe-list>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	6.3	CC:	amsharma, jgalipea
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	389-ds-base-1.2.10.0-1.el6	Doc Type:	Bug Fix
Doc Text:	Cause: Using search filters with many substring filters and attributes that require a lot of normalization (such as DN syntax value). Consequence: Poor performance due to excessive normalization and regex compilation. Change: The code will now pre-compile and pre-normalize such search filters. Result: Better performance for search filters with many substring filters and attributes that require a lot of normalization.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-06-20 07:11:47 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Rich Megginson 2012-01-09 23:07:39 UTC

This bug is created as a clone of upstream ticket:
https://fedorahosted.org/389/ticket/1

When processing large search filters which are applied to every entry in the search result set, the filter is normalized anew each time a new entry is tested.  For substring filters, a regular expression must be created, compiled, and freed each time the substring filter is tested, in addition to normalizing the values.  For example, if the search filter contains 1000 substring sub-filters, for each entry tested with the filter, this will require 1000 filter normalizations followed by 1000 regex creation, compilation, and cleanup.  If there are 1000 entries in the search result set, this will require a million such operations.

Comment 1 Jenny Severance 2012-01-13 18:04:34 UTC

please add steps to reproduce/verify this issue
Thanks

Comment 3 Rich Megginson 2012-04-17 20:13:50 UTC

svn ci -m "added tests for Bug 772777 - pre compile and normalize search filter" data/DS/6.0/filter/en/bigdneq.filt data/DS/6.0/filter/en/bigdnsub.filt data/DS/6.0/filter/en/filters.ldif testcases/DS/6.0/filter/tet_scen.sh testcases/DS/6.0/filter/filter.sh
Adding         data/DS/6.0/filter/en/bigdneq.filt
Adding         data/DS/6.0/filter/en/bigdnsub.filt
Sending        data/DS/6.0/filter/en/filters.ldif
Sending        testcases/DS/6.0/filter/filter.sh
Sending        testcases/DS/6.0/filter/tet_scen.sh
Transmitting file data .....
Committed revision 6471.

RHEL6.3 branch

Comment 4 Amita Sharma 2012-04-24 06:55:59 UTC

Filter test suit is passing 100%, hence marking this bug as VERIFIED.

Comment 5 Rich Megginson 2012-05-24 22:31:29 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause: Using search filters with many substring filters and attributes that require a lot of normalization (such as DN syntax value).
Consequence: Poor performance due to excessive normalization and regex compilation.
Change: The code will now pre-compile and pre-normalize such search filters.
Result: Better performance for search filters with many substring filters and attributes that require a lot of normalization.

Comment 6 errata-xmlrpc 2012-06-20 07:11:47 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-0813.html