Bug 773175

Summary:	It now takes two clicks to start translating
Product:	[Retired] Zanata	Reporter:	Sean Flanigan <sflaniga>
Component:	Component-UI	Assignee:	Alex Eng <aeng>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Carlos Munoz <camunoz>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	1.5-SNAPSHOT	CC:	aeng, camunoz, damason, zanata-bugs
Target Milestone:	Sprint-31
Target Release:	1.5
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	1.5.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-03-07 00:06:59 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	786670

Description Sean Flanigan 2012-01-11 06:31:10 UTC

Description of problem:
As of 1.5, empty cells say "click here to start translating", but if the cell is not part of the current row, the first click just selects the row, and only the second click opens the editor.

Version-Release number of selected component (if applicable):
1.5-SNAPSHOT (2012-01-17)

How reproducible:
always

Steps to Reproduce:
1. click in the second row's editor cell
  
Actual results:
cell row is selected, but editor is not opened

Expected results:
cell row is selected, and editor is opened

Additional info:

Comment 1 Sean Flanigan 2012-01-11 06:47:51 UTC

The same problem occurs when clicking from editor to editor.  The first editor cell closes, but the editor on the new row doesn't open unless I click in the editor area a second time.

Comment 2 Alex Eng 2012-02-14 04:57:02 UTC

Bug fix. See https://github.com/zanata/zanata/commit/246f648924ed5c40ae98341a460fdbe4d63e7194

Comment 3 Alex Eng 2012-02-14 05:21:20 UTC

Re-implement with event based solution: See https://github.com/zanata/zanata/commit/3712e6a2a19057677bd1002b5e7532d70ffade4f

Comment 4 Sean Flanigan 2012-02-14 07:51:13 UTC

Can you please make sure we only trigger the editor when using the left mouse button (and no modifiers)?  Having the editor trigger on RMB makes using DOM inspectors *extremely* difficult.

Comment 5 David Mason 2012-02-21 02:40:41 UTC

Two clicks are still required to start translating. The editor now opens with one click, but about 90% of the time in Chrome and Firefox 3.6 the editor does not have focus, so translation cannot be initiated without an extra click to focus the editor.

Comment 6 Alex Eng 2012-02-23 05:19:14 UTC

Fix issues: https://bugzilla.redhat.com/show_bug.cgi?id=773175#c5

See
https://github.com/zanata/zanata/commit/1331838374a897a9a16411804b56294d9a65ebd7

Comment 7 Alex Eng 2012-02-24 00:02:49 UTC

Fix found issues with https://bugzilla.redhat.com/show_bug.cgi?id=773175#c6.

See https://github.com/zanata/zanata/commit/20fbedb5d53122aabe3d16158c870ecae909a91b

Comment 8 Carlos Munoz 2012-02-24 00:40:55 UTC

Works on Firefox 3.6, but on Chrome it still is not opening the editor on the first click. I found it will open the editor on the first click randomly when clicking just outside the "click here" text.

Comment 9 Carlos Munoz 2012-02-27 06:04:29 UTC

Verified with Zanata version 1.5.0-alpha-3-SNAPSHOT (20120227-1458).