Bug 773208

Summary: Migration with non-existent xml does not report error
Product: Red Hat Enterprise Linux 6 Reporter: weizhang <weizhan>
Component: libvirtAssignee: Alex Jia <ajia>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.3CC: acathrow, ajia, dyuan, mzhan, rwu, veillard, zhpeng
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: libvirt-0.9.10-1.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-06-20 06:46:18 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description weizhang 2012-01-11 09:14:56 UTC 
Description of problem:
Migration with non-existent xml does not report error messages although it returns non-zero value


Version-Release number of selected component (if applicable):
kernel-2.6.32-223.el6.x86_64
libvirt-0.9.9-1.el6.x86_64
qemu-kvm-0.12.1.2-2.213.el6.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Prepare migration environment with shared nfs dir and start a guest

2. Do migration with
# virsh migrate kvm-rhel6u2-x86_64-new --live qemu+ssh://10.66.83.197/system --xml non-existent-xml
no error messages here and migration returns immediately 

3. Check return value
# echo $?
1
  
Actual results:
It does not report any error messages

Expected results:
It should report error messages

Additional info:
Comment 2 Alex Jia 2012-01-11 09:23:06 UTC 
Patch for upstream:
https://www.redhat.com/archives/libvir-list/2012-January/msg00388.html
Comment 3 Alex Jia 2012-01-11 14:53:33 UTC 
In POST:
commit c41a21de3abb6a080d87360ed7b246b070703b88
Author: Alex Jia <ajia>
Date:   Wed Jan 11 16:23:03 2012 +0800

    virsh: improve doMigrate function docs
    
    When running virsh migrate with --xml option and actual xml file doesn't
    exist, virsh hasn't output any error information, although return value
    is 1.
    
    * tools/virsh.c: Raising a appropriate error information when operation fails.
    
    * How to reproduce?
    % virsh migrate <domain> --live qemu+ssh://<target host>/system --xml non-existent.xml
    % echo $?
    
    * Fixed result:
    error: file 'non-existent.xml' doesn't exist
    
    Signed-off-by: Alex Jia <ajia>
Comment 5 weizhang 2012-02-14 11:11:12 UTC 
Verify pass on 
libvirt-0.9.10-1.el6.x86_64
qemu-kvm-0.12.1.2-2.225.el6.x86_64
kernel-2.6.32-230.el6.x86_64

# virsh migrate --live tt qemu+ssh://10.66.85.218/system --xml none-exist.xml
error: file 'none-exist.xml' doesn't exist
Comment 7 errata-xmlrpc 2012-06-20 06:46:18 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-0748.html