| Summary: | [vdsm] cancel-migration: abort migration on dest when vm is during migration results an exception | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Retired] oVirt | Reporter: | Haim <hateya> | ||||
| Component: | vdsm | Assignee: | Shahar Havivi <shavivi> | ||||
| Status: | CLOSED WORKSFORME | QA Contact: | |||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | unspecified | CC: | abaron, acathrow, bazulay, hateya, iheim, mgoldboi, yeylon, ykaul | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | virt | ||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2012-10-18 07:42:37 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
can you attach the full log? Created attachment 552455 [details]
vdsm log
still relevant, cannot reproduce... (In reply to comment #3) > still relevant, cannot reproduce... no capacity of testing the flow again. |
Description of problem: - run migration cancel using vdsClient on destination server where vm is on migrating-dest results an AttribureError: Thread-177::ERROR::2012-01-11 10:03:22,823::clientIF::90::vds::(wrapper) Traceback (most recent call last): File "/usr/share/vdsm/clientIF.py", line 80, in wrapper res = f(*args, **kwargs) File "/usr/share/vdsm/clientIF.py", line 415, in migrateCancel return vm.migrateCancel() File "/usr/share/vdsm/vm.py", line 1017, in migrateCancel self._migrationSourceThread.stop() File "/usr/share/vdsm/libvirtvm.py", line 454, in stop self._vm._dom.abortJob() AttributeError: 'NoneType' object has no attribute 'abortJob 449 def stop(self): 450 # if its locks we are before the migrateToURI2() 451 # call so no need to abortJob() 452 try: 453 self._migrationCanceledEvt = True 454 self._vm._dom.abortJob() we should check if object is not None before using it, if None, raise proper error. 455 except libvirt.libvirtError, e: 456 # TODO: yes its not nice searching in the error message, 457 # but this is the libvrirt solution 458 # this will be solved at bz #760149 459 if e.get_error_code() == libvirt.VIR_ERR_OPERATION_FAILED and \ 460 'canceled by client' in e.get_error_message(): 461 # this is exception that libvirt raise when calling 462 # abortJob() 463 raise 464 elif not self._preparingMigrationEvt: 465 raise