Bug 773572

Summary: [doc] The unit for bandwidth in block_pull and set_block_job_speed method should be MB/s
Product: Red Hat Enterprise Linux 6 Reporter: xhu
Component: perl-Sys-VirtAssignee: Daniel Berrangé <berrange>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: low Docs Contact:
Priority: low    
Version: 6.3CC: mshao, mzhan, rwu
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Sys-Virt-0.9.10-2.el6 Doc Type: Bug Fix
Doc Text:
No technical notes required
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-06-20 12:00:55 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description xhu 2012-01-12 09:55:15 UTC
Description of problem:
The unit for bandwidth in block_pull and set_block_job_speed method should be MB/s

Version-Release number of selected component (if applicable):
perl-Sys-Virt-0.9.9-1.el6.x86_64

How reproducible:
everytimes

Steps to Reproduce:
1. 
# man /usr/share/man/man3/Sys::Virt::Domain.3pm.gz
...
$dom->set_block_job_speed($path, $bandwidth, $flags=0)
           Change the maximum I/O bandwidth used by the block job that is currently executing for $path. The $bandwidth argument is specified in KB/s
...
$dom->block_pull($path, $bandwith, $flags=0)
           Merge the backing files associated with $path into the top level file. The $bandwidth parameter specifies the maximum I/O rate to allow in
           KB/s.
...
2.
set $bandwidth=1 and use $dom->block_pull($path, $bandwith, $flags=0) to start block pull

3. check the bandwith
# virsh blockjob tck /var/cache/libvirt-tck/storage-fs/tck/tck-main --info
Block Pull: [ 12 %]    Bandwidth limit: 2 MB/s

Actual results:
The unit for bandwidth in block_pull and set_block_job_speed method is KB/s

Expected results:
The unit for bandwidth in block_pull and set_block_job_speed method should be MB/s

Additional info:

Comment 1 Daniel Berrangé 2012-02-15 14:07:57 UTC
*** Bug 773569 has been marked as a duplicate of this bug. ***

Comment 3 xhu 2012-03-05 07:23:46 UTC
Verify it with perl-Sys-Virt-0.9.10-2.el6 and it passed.
1. 
# man /usr/share/man/man3/Sys::Virt::Domain.3pm.gz
...
$dom->set_block_job_speed($path, $bandwidth, $flags=0)
           Change the maximum I/O bandwidth used by the block job that is
currently executing for $path. The $bandwidth argument is specified in MB/s
...
$dom->block_pull($path, $bandwith, $flags=0)
           Merge the backing files associated with $path into the top level
file. The $bandwidth parameter specifies the maximum I/O rate to allow in
           MB/s.
...

Comment 5 Daniel Berrangé 2012-05-01 09:07:20 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
No technical notes required

Comment 7 errata-xmlrpc 2012-06-20 12:00:55 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0754.html