Bug 773675

Summary: Disable LRO for all NICs that have LRO enabled
Product: Red Hat Enterprise Linux 6 Reporter: Chris Pelland <cpelland>
Component: ovirt-nodeAssignee: Mike Burns <mburns>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 6.3CC: acathrow, agospoda, apevec, bsarathy, cpelland, djuran, dledford, dyasny, fyu, gouyang, jboggs, jturner, leiwang, llim, mburns, moli, mwagner, nhorman, ovirt-maint, pcao, plundin, plyons, pm-eus, sghosh, sgordon, tvvcox, vbian, ycui, yeylon
Target Milestone: rcKeywords: ZStream
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: ovirt-node-2.0.2-0.14.3.git3eac501.el6_2.2 Doc Type: Bug Fix
Doc Text:
Previously, when an NIC was added to a bridge LRO would not automatically be disabled if a bond was also present. The use of a bond and a bridge on top of NICs using LRO presented serious performance degradation. This update ensures that LRO is disabled on all NICs, avoiding this performance degradation issue.
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-01-23 18:17:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 772806    
Bug Blocks:    

Description Chris Pelland 2012-01-12 14:51:54 UTC
This bug has been copied from bug #772806 and has been proposed
to be backported to 6.2 z-stream (EUS).

Comment 4 Mike Burns 2012-01-12 15:36:14 UTC
See patch in bug 772806

Comment 6 Mike Burns 2012-01-12 17:41:56 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
A serious performance problem occurs when running using a bond and a bridge on top of NICs that use LRO.  LRO should get disabled automatically when the NIC is added to a bridge but this doesn't work right when there is a bond in between.  This patch disables LRO on all nics.

Comment 7 Stephen Gordon 2012-01-12 19:53:19 UTC
    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1 +1 @@
-A serious performance problem occurs when running using a bond and a bridge on top of NICs that use LRO.  LRO should get disabled automatically when the NIC is added to a bridge but this doesn't work right when there is a bond in between.  This patch disables LRO on all nics.+Previously, when an NIC was added to a bridge LRO would not automatically be disabled if a bond was also present. The use of a bond and a bridge on top of NICs using LRO presented serious performance degradation. This update ensures that LRO is disabled on all NICs, avoiding this performance degradation issue.

Comment 8 Guohua Ouyang 2012-01-18 09:06:56 UTC
On rhevh-6.2-20120117, LRO is disabled for all NICs now.

[root@unused admin]# cat /etc/modprobe.d/bnx2x.conf 
options bnx2x disable_tpa=1


Hi Mike, 
is above information is enough to close this bug? if not, could you ask customer to verify this bug in their environment?

Comment 9 Mike Burns 2012-01-18 13:00:04 UTC
That should be sufficient.  Please confirm that it's disabled when nics are bonded as well.

Thanks

Comment 10 Andy Gospodarek 2012-01-18 13:28:38 UTC
It will be sufficient for any bnx2x hardware, but will not be useful for other hardware that needs LRO disabled.

Comment 11 Mike Burns 2012-01-18 13:35:59 UTC
(In reply to comment #10)
> It will be sufficient for any bnx2x hardware, but will not be useful for other
> hardware that needs LRO disabled.

Hi Andy,

This is what we're doing:

echo "options bnx2x disable_tpa=1" > /etc/modprobe.d/bnx2x.conf
echo "options mlx4_en num_lro=0" > /etc/modprobe.d/mlx4_en.conf
echo "options enic lro_disable=1" > /etc/modprobe.d/enic.conf
echo "options s2io lro=0" > /etc/modprobe.d/s2io.conf

Are we missing anything?  These were the options given to us back in the 5.x timeframe.

Comment 12 Mike Burns 2012-01-20 14:53:42 UTC
Dropping needinfo, we're covering everything.

Comment 13 Ying Cui 2012-01-20 14:58:37 UTC
According to comment 8, comment 9 and comment 12, I change the bug status to 'Verified.'

Comment 14 errata-xmlrpc 2012-01-23 18:17:25 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0048.html