Bug 778050 (SOA-575)

Link: Added: This issue depends JBMESSAGING-1370

seems like config issue from our side - see linked issue

The problem appears to be that we overwrite the configuration by copying files from the:
  build-tools/resource/schema/common
directory in the SOA-P source.  Because of changes in the files between JBM releases, we
are now installing inappropriate configurations.

Must be fixed in CP02.

Fixed in revision 1334 of:
  build-tools/builders/eap/build.xml
  build-tools/builders/esb/build.xml

Log message:

  Don't use/copy local versions of the JBM config.
  Use the ones from the EAP docs/examples/jms directory instead.

  Fixes JIRA SOA-575.

It's fixed in embedded/production server - but - It's still there in the standalone server:

[ldimaggi@ldimaggi Desktop]$ ll server_*
-rw-rw-r-- 1 ldimaggi ldimaggi   68578 Jun 13 15:53 server_production_CP02_CR2.log
-rw-rw-r-- 1 ldimaggi ldimaggi 3524306 Jun 13 15:38 server_standalone_CP02_CR2.log

[ldimaggi@ldimaggi Desktop]$ grep NODEID server_*
server_standalone_CP02_CR2.log:2008-06-13 15:36:00,574 DEBUG [org.jboss.messaging.core.impl.JDBCSupport] Failed to execute: CREATE TABLE JBM_ID_CACHE (NODE_ID INTEGER, CNTR INTEGER, JBM_ID VARCHAR(255), PRIMARY KEY(NODEID, CNTR))
server_standalone_CP02_CR2.log:java.sql.SQLException: Column not found: NODEID in statement [CREATE TABLE JBM_ID_CACHE (NODE_ID INTEGER, CNTR INTEGER, JBM_ID VARCHAR(255), PRIMARY KEY(NODEID, CNTR)]

Attachment: Added: server_production_CP02_CR2.log
Attachment: Added: server_standalone_CP02_CR2.log

dist-diff output on embedded server:

[ldimaggi@ldimaggi dist-diff]$ ant | grep -v doc
Buildfile: build.xml

init:

diff:
[dist-diff] Difference found in jbossesb-rosetta.jar at VERSION
[dist-diff] Difference found in jbossesb-rosetta.jar at VERSION
[dist-diff] Difference found in jbossesb-rosetta.jar at VERSION
[dist-diff] Difference found in jbossesb-rosetta.jar at VERSION
[dist-diff] ================================================================================
[dist-diff] Differences found
[dist-diff]     Additions (not a problem)
[dist-diff]             jboss-as/tools/schema/common/ndb-persistence-service.xml
[dist-diff]     Removals
[dist-diff]     Modifications
[dist-diff]             jbpm-jpdl/examples/websale/target/websale.jpdl
[dist-diff]             jbpm-jpdl/db/compatibility.html
[dist-diff]             jboss-as/server/production/deploy/soapui-client.sar/jbossesb-rosetta.jar
[dist-diff]             jboss-as/server/production/deploy/jbossesb.sar/lib/jbossesb-rosetta.jar
[dist-diff]             jboss-as/server/all/deploy/soapui-client.sar/jbossesb-rosetta.jar
[dist-diff]             jboss-as/server/all/deploy/jbossesb.sar/lib/jbossesb-rosetta.jar
[dist-diff] ================================================================================

BUILD SUCCESSFUL
Total time: 5 minutes 14 seconds

The issue is not related only to config files! If the hsqldb config is used then the statements are not defined in hsqldb-persistence-service.xml but is hardcoded in JBoss Messaging source files.

See http://anonsvn.jboss.org/repos/messaging/tags/JBossMessaging_1_4_0_SP3_CP02/src/main/org/jboss/messaging/core/impl/JDBCPersistenceManager.java

Method
   protected Map getDefaultDDLStatements()
   {
...
      map.put("CREATE_ID_CACHE", "CREATE TABLE JBM_ID_CACHE (NODE_ID INTEGER, CNTR INTEGER, JBM_ID VARCHAR(255), PRIMARY KEY(NODEID, CNTR))");

See the typo in PRIMARY KEY definition

Just to clarify since there seems to be confusion on this task, there are actually two separate issues here

1) The SOA config being used in the build is for an older version of JBM - this is easy to fix - just use the old version

2) There is a typo in the default config for JBM 1.4.SP3_CP02. This will only effect users trying to start using hsql. There is a simple workaround for this that does not require any new JBM build - just add the correct config line to the xml file.

I meant, of course, "just use the correct version" in the above comment :)

SOA-586 documents a new bug found when this bug was fixed.

Link: Added: This issue is related to SOA-586

Link: Removed: This issue depends JBMESSAGING-1370 

Verified resolved in CP02 CR4 (actually - it was also fixed in CR2)

[ldimaggi@ldimaggi log]$ grep NODE_ID server.log 
   CREATE_TRANSACTION=CREATE TABLE JBM_TX (NODE_ID INTEGER, TRANSACTION_ID BIGINT, BRANCH_QUAL VARBINARY(254), FORMAT_ID INTEGER, GLOBAL_TXID VARBINARY(254), PRIMARY KEY (TRANSACTION_ID))
   CREATE_ID_CACHE=CREATE TABLE JBM_ID_CACHE (NODE_ID INTEGER, CNTR INTEGER, JBM_ID VARCHAR(255), PRIMARY KEY(NODE_ID, CNTR))
   INSERT_TRANSACTION=INSERT INTO JBM_TX (NODE_ID, TRANSACTION_ID, BRANCH_QUAL, FORMAT_ID, GLOBAL_TXID) VALUES(?, ?, ?, ?, ?)
   DELETE_TRANSACTION=DELETE FROM JBM_TX WHERE NODE_ID = ? AND TRANSACTION_ID = ?
   SELECT_PREPARED_TRANSACTIONS=SELECT TRANSACTION_ID, BRANCH_QUAL, FORMAT_ID, GLOBAL_TXID FROM JBM_TX WHERE NODE_ID = ?
   UPDATE_TX=UPDATE JBM_TX SET NODE_ID=? WHERE NODE_ID=?
   UPDATE_ID_IN_CACHE=UPDATE JBM_ID_CACHE SET JBM_ID = ? WHERE NODE_ID = ? AND CNTR = ?
   INSERT_ID_IN_CACHE=INSERT INTO JBM_ID_CACHE (NODE_ID, CNTR, JBM_ID) VALUES (?, ?, ?)
   LOAD_ID_CACHE=SELECT CNTR, JBM_ID FROM JBM_ID_CACHE WHERE NODE_ID = ? in jboss.messaging:service=PersistenceManager

[ldimaggi@ldimaggi log]$ grep NODEID server.log 
[ldimaggi@ldimaggi log]$ 

Link: Added: This issue is related to SOA-849