Bug 778754 (SOA-1209)

Summary: Schema tool does not correctly update jbpm-service.xml file
Product: [JBoss] JBoss Enterprise SOA Platform 4 Reporter: Jiri Pechanec <jpechane>
Component: Tooling, DeploymentAssignee: Julian Coleman <jcoleman>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: urgent Docs Contact:
Priority: urgent    
Version: 4.3 CP01   
Target Milestone: ---   
Target Release: 4.3 CP01   
Hardware: Unspecified   
OS: Unspecified   
URL: http://jira.jboss.org/jira/browse/SOA-1209
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-04-08 13:07:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Jiri Pechanec 2009-03-06 07:13:29 UTC
Date of First Response: 2009-03-06 09:51:40
project_key: SOA

The jbpm-service.xml file contains commands to create or update the database
    <mbean code="org.jboss.internal.soa.esb.dependencies.DatabaseInitializer"
       name="jboss.esb:service=JBPMDatabaseInitializer">
      <attribute name="Datasource">java:/JbpmDS</attribute>
      <attribute name="ExistsSql">select * from JBPM_ID_USER</attribute>
      <attribute name="SqlFiles">
      jbpm-sql/jbpm.jpdl.hsqldb.sql
      </attribute>
      <depends>jboss.jca:service=DataSourceBinding,name=JbpmDS</depends>
      <attribute name="UseEOL">true</attribute>
    </mbean>

   <mbean code="org.jboss.internal.soa.esb.dependencies.DatabaseInitializer"
       name="jboss.esb:service=JBPMDatabaseUpgrader">
      <attribute name="Datasource">java:/JbpmDS</attribute>
      <attribute name="ExistsSql">select PARENTLOCKMODE_ from JBPM_NODE</attribute>
      <attribute name="SqlFiles">
      jbpm-sql/jbpm.jpdl.hsqldb.update322.sql
      </attribute>
      <depends>jboss.esb:service=JBPMDatabaseInitializer</depends>
      <attribute name="UseEOL">true</attribute>
    </mbean>

but if the scheam tool is udes only the first (create) script is updated
   <mbean code="org.jboss.internal.soa.esb.dependencies.DatabaseInitializer"
       name="jboss.esb:service=JBPMDatabaseInitializer">
      <attribute name="Datasource">java:/JbpmDS</attribute>
      <attribute name="ExistsSql">select * from JBPM_ID_USER</attribute>
      <attribute name="SqlFiles">
      jbpm-sql/jbpm.jpdl.postgresql.sql
      </attribute>
      <depends>jboss.jca:service=DataSourceBinding,name=JbpmDS</depends>
      <attribute name="UseEOL">true</attribute>
    </mbean>

   <mbean code="org.jboss.internal.soa.esb.dependencies.DatabaseInitializer"
       name="jboss.esb:service=JBPMDatabaseUpgrader">
      <attribute name="Datasource">java:/JbpmDS</attribute>
      <attribute name="ExistsSql">select PARENTLOCKMODE_ from JBPM_NODE</attribute>
      <attribute name="SqlFiles">
      jbpm-sql/jbpm.jpdl.hsqldb.update322.sql
      </attribute>
      <depends>jboss.esb:service=JBPMDatabaseInitializer</depends>
      <attribute name="UseEOL">true</attribute>
    </mbean>

The update is still using HSQLDB specific script

Comment 1 Julian Coleman 2009-03-06 14:51:40 UTC
Fixed with revision 2758 (4.3 branch) of:
  build-tools/resource/schema/tool/esb/build.xml

Commit message:
  Catch all *.jpdl.hsqldb.* instances when renaming.
  Fixes JIRA SOA-1209.


Comment 2 Jiri Pechanec 2009-03-12 11:45:11 UTC
Verified in CR4

Comment 3 Julian Coleman 2009-03-30 12:06:27 UTC
We no longer need upgrade scripts.  See SOA-1176.

Comment 4 Julian Coleman 2009-03-30 12:10:15 UTC
Link: Added: This issue is related to SOA-1176


Comment 5 Julian Coleman 2009-03-30 12:39:24 UTC
The modification in revision 2758 (4.3 branch) of: 
   build-tools/resource/schema/tool/esb/build.xml 
 
is applicable with or without the upgrade scripts, so no further work
needs to be done here.


Comment 7 Jiri Pechanec 2009-04-08 13:07:09 UTC
Verified in CR7