Bug 779676 (SOA-2041)

Summary:	Adding description to expression in script
Product:	[JBoss] JBoss Enterprise SOA Platform 5	Reporter:	Toshiya Kobayashi <tkobayas>
Component:	Documentation	Assignee:	David Le Sage <dlesage>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.2.0 GA	CC:	tkobayas
Target Milestone:	---
Target Release:	5.3.0 GA
Hardware:	Unspecified
OS:	Unspecified
URL:	http://jira.jboss.org/jira/browse/SOA-2041
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-07-31 04:49:09 UTC	Type:	Feature Request
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Toshiya Kobayashi 2010-04-17 15:23:58 UTC

Affects: Documentation (Ref Guide, User Guide, etc.)
Help Desk Ticket Reference: https://enterprise.redhat.com/issue-tracker/501573
project_key: SOA

http://www.redhat.com/docs/en-US/JBoss_SOA_Platform/4.3.CP02/html-single/JBPM_Reference_Manual/index.html#script.element

The description of "expression"

===
the beanshell script. If you don't specify variable[b] elements, you can write the expression as the content of the script element (omitting the expression element tag).
=== 

This description is a bit confusing for users who think "expression as the content of the script element" is the basic function of script element. So I'd like to add one sentence to it, though it might be verbose.

===
the beanshell script. If you don't specify variable[b] elements, you can write the expression as the content of the script element (omitting the expression element tag). If you use "expression as the content of the script element" with variable and/or expression elements, the content of the script element will be ignored.
===

Comment 1 Toshiya Kobayashi 2010-04-17 15:26:20 UTC

Source code is easier to understand :)

http://anonsvn.jboss.org/repos/jbpm/jbpm3/tags/jbpm-3.2.7.CR3/modules/core/src/main/java/org/jbpm/graph/action/Script.java

 public void read(Element scriptElement, JpdlXmlReader jpdlReader) {
   if (scriptElement.isTextOnly()) {
     expression = scriptElement.getText();
   } else {
     this.variableAccesses = new HashSet(jpdlReader.readVariableAccesses(scriptElement));
     expression = scriptElement.element("expression").getText();
   }
 }

Comment 2 David Le Sage 2011-07-18 00:34:07 UTC

Release Notes Docs Status: Added: Not Required
Writer: Added: dlesage

Comment 3 David Le Sage 2011-07-18 00:37:13 UTC

Modified paragraph and sample source code added to the document.  Thanks.

Comment 4 Martin Vecera 2011-11-15 09:02:40 UTC

I believe that Toshiya posted the source code here to demonstarte the functionality for you to provide enough information to fix the documentation.

It is not a sample code, it shows internals of SOA-P that are likely to change.

This code should not be present in the docs definitely!

Comment 5 Toshiya Kobayashi 2011-11-22 00:58:28 UTC

Aha, Martin is correct. I just pasted the source code from actual jbpm source so that we can understand how script element works.
Please remove it from the document :)

Comment 6 Len DiMaggio 2011-11-29 17:15:26 UTC

Link: Added: This issue Cloned to SOA-3638