Bug 779808 (SOA-2171)

Summary:	http-client-properties not propagated to HttpMethodParams
Product:	[JBoss] JBoss Enterprise SOA Platform 5	Reporter:	david.boeren <david.boeren>
Component:	JBossESB	Assignee:	Kevin Conner <kevin.conner>
Status:	CLOSED NEXTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	high
Version:	5.0.0 GA
Target Milestone:	---
Target Release:	5.1.0.ER1
Hardware:	Unspecified
OS:	Unspecified
URL:	http://jira.jboss.org/jira/browse/SOA-2171
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-03-03 00:22:43 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description david.boeren 2010-07-23 15:56:47 UTC

Help Desk Ticket Reference: https://access.redhat.com/issue-tracker/?module=issues&action=view&tid=1148953&gid=1354
Workaround Description: There is no known workaround.
project_key: SOA

If you set your config like this:

<action ... class="org.jboss.soa.esb.actions.soap.proxy.SOAPProxy">
    ...
    <property name="http-client-properties">
        <http-client-property name="http.method.retry-handler" value="com.foobar.MyRetryHandler"/>
    </property>

or like this:

<action ... class="org.jboss.soa.esb.actions.soap.proxy.SOAPProxy">
    ...
    <property name="file" value="http-client.properties"/>

http-client.properties:
http.method.retry-handler=com.foobar.MyRetryHandler

, your custom retry handler is not picked up. This is NOT a bug in SOAPProxy.

The bug is in both POSTHttpMethodFactory and GETHttpMethodFactory, where in the setConfiguration(ConfigTree):void method, the http-client-properties that are available in the passed-in ConfigTree are not set into the HttpMethod's HttpMethodParams.

What should happen is that ANY property that starts with "http.method." should be set into the HttpMethodParams.

Comment 1 david.boeren 2010-07-23 15:57:28 UTC

Link: Added: This issue depends JBESB-3378

Comment 2 Darran Lofthouse 2010-08-09 11:28:17 UTC

Link: Added: This issue is incorporated by SOA-2210

Comment 3 Kevin Conner 2010-08-10 15:14:52 UTC

Link: Removed: This issue is incorporated by SOA-2210

Comment 4 Kevin Conner 2010-08-10 16:29:19 UTC

Link: Added: This issue related SOA-2224

Comment 5 Kevin Conner 2010-08-20 09:49:47 UTC

Link: Added: This issue depends JBESB-3468

Comment 6 Anne-Louise Tangring 2010-09-10 16:23:56 UTC

According to Kevin, this is not a valid issue as reported. Even so, it's post ESB 4.9. Actual issues related to this are resolved and in 5.1 already.

Comment 7 Kevin Conner 2010-09-10 16:29:14 UTC

To clarify, the suggested fix is not valid as it is not possible to propagate all 'http.method.' properties to the HttpMethodParams.

The specific issue of configuring the retry handler has been addressed in JBESB-3378.

Comment 8 David Le Sage 2011-03-01 05:30:52 UTC

Temporarily reopening to update release note info.

Comment 9 David Le Sage 2011-03-01 05:37:23 UTC

https://issues.jboss.org/browse/JBESB-3378

There was a bug in both POSTHttpMethodFactory and GETHttpMethodFactory, in which the setConfiguration(ConfigTree):void method's http-client-properties were not set into the HttpMethod's HttpMethodParams. This meant that any custom retry handlers were ignored.  This bug has now been rectified so that any property that starts with "http.method." is set into HttpMethodParams. As a result, custom retry handlers are now detected correctly.

Comment 10 David Le Sage 2011-03-01 05:37:23 UTC

Release Notes Docs Status: Added: Documented as Resolved Issue
Writer: Added: dlesage

Comment 11 David Le Sage 2011-03-03 00:21:59 UTC

Temporarily reopening to fix release note.

Comment 12 David Le Sage 2011-03-03 00:22:14 UTC

Release Notes Text: Added: https://issues.jboss.org/browse/JBESB-3378

There was a bug in both POSTHttpMethodFactory and GETHttpMethodFactory, in which the setConfiguration(ConfigTree):void method's http-client-properties were not set into the HttpMethod's HttpMethodParams. This meant that any custom retry handlers were ignored. This bug has now been rectified so that any property that starts with "http.method." is set into HttpMethodParams. As a result, custom retry handlers are now detected correctly.