Bug 779823 (SOA-2184)

Help Desk Ticket Reference: https://access.redhat.com/issue-tracker/?module=issues&action=view&tid=1168653&gid=1354
project_key: SOA

There seems to be a bug in the private void injectParameters(Element element, Map params, String soapNs) function in the org.jboss.soa.esb.services.soapui.SoapUIClientService class.

The problem is that given a WSDL than takes many optional parameters (only a simple body supplied here):

  <soapenv:Body>
     <ser:getLogicalDate soapenv:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/">
        <getLogicalDateRequest xsi:type="dto:GetLogicalDateRequest" xmlns:dto="http://dto.telenor.dk">
           <businessCorrelationId xsi:type="xsd:string">?</businessCorrelationId>
           <businessCorrelationIdType xsi:type="xsd:string">?</businessCorrelationIdType>
           <systemId xsi:type="xsd:string">?</systemId>
        </getLogicalDateRequest>
     </ser:getLogicalDate>
  </soapenv:Body>

And an OGNL expression as follows:

getLogicalDateRequest.businessCorrelationId = "XXX"

That is not specifying the two other parameters the action will generate a request that looks like this:

  <soapenv:Body>
     <ser:getLogicalDate soapenv:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/">
        <getLogicalDateRequest xsi:type="dto:GetLogicalDateRequest" xmlns:dto="http://dto.telenor.dk">
           <businessCorrelationId xsi:type="xsd:string">XXX</businessCorrelationId>
           <businessCorrelationIdType xsi:type="xsd:string"></businessCorrelationIdType>
           <systemId xsi:type="xsd:string"></systemId>
        </getLogicalDateRequest>
     </ser:getLogicalDate>
  </soapenv:Body>

Which is incorrect as the code behind the web service will assume that businessCorrelationIdType and systemId are the empty String not null as they should be. A more correct request would be:

  <soapenv:Body>
     <ser:getLogicalDate soapenv:encodingStyle="http://schemas.xmlsoap.org/soap/encoding/">
        <getLogicalDateRequest xsi:type="dto:GetLogicalDateRequest" xmlns:dto="http://dto.telenor.dk">
           <businessCorrelationId xsi:type="xsd:string">XXX</businessCorrelationId>
        </getLogicalDateRequest>
     </ser:getLogicalDate>
  </soapenv:Body>

This extends to complex Elements (ie. and element where nothing is set should be sent to the web service).