Bug 779999 (SOA-2359)

Summary: Multiple files with the same name in ModeShape jars
Product: [JBoss] JBoss Enterprise SOA Platform 5 Reporter: Julian Coleman <jcoleman>
Component: Build Process, Distribution, EDSAssignee: Van Halbert <vhalbert>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: high    
Version: 5.1.0.ER2   
Target Milestone: ---   
Target Release: 5.1.0 GA   
Hardware: Unspecified   
OS: Unspecified   
URL: http://jira.jboss.org/jira/browse/SOA-2359
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
SOA 5.1.0 ER2 EDS zip
Last Closed: 2011-02-07 16:51:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Julian Coleman 2010-09-29 11:11:37 UTC
project_key: SOA

The jar files:

  modeshape/client/modeshape-client.jar
  modeshape/tools/modeshape-jpa-ddl-gen.jar

contain multiple files with the same name (or similar names) in the META-INF directory.
This causes jar signing to break.

modeshape-client.jar:
      2 META-INF/DEPENDENCIES
      5 META-INF/LICENSE
      1 META-INF/LICENSE.txt
      4 META-INF/NOTICE

modeshape-jpa-ddl-gen.jar:
      1 META-INF/LICENSE
      4 META-INF/LICENSE.txt
      1 META-INF/license.txt
      1 META-INF/NOTICE
      3 META-INF/NOTICE.txt

Comment 1 Dan Florian 2010-09-29 14:46:29 UTC
Link: Added: This issue is a dependency of JBDS-1312


Comment 2 Van Halbert 2010-09-29 18:05:32 UTC
Link: Added: This issue depends MODE-921


Comment 3 Van Halbert 2010-10-03 20:16:13 UTC
With the change to the modeshape-jpa-ddl-gen tool being unbundled and having scripts added to execute, this will require changes to soa-p build to pick up accordingly.

Comment 4 Van Halbert 2010-10-04 01:28:10 UTC
The following are how the changes were made:
-  duplicates were removed from the modeshape-client.jar
-  modeshape-jpa-ddl-gen.jar has been unbundled, containing all the dependency jar's.   Also, scripts were added to improve usable for execution.

These changes will be available to the ER3 build.

Comment 5 Van Halbert 2010-12-13 17:07:24 UTC
Adjusted the assembly to remove duplicates for NOTICE and LICENSE.

The change to kit.xml has been committed to the 2.2.x product branch.

Comment 6 Julian Coleman 2010-12-22 15:07:38 UTC
Link: Added: This issue related SOA-2718


Comment 8 Dana Mison 2011-01-05 00:08:19 UTC
Writer: Added: Darrin


Comment 9 Len DiMaggio 2011-02-07 16:51:43 UTC
Verified fixed in ER9 build:

[ldimaggi@ldimaggi jboss-soa-p-5]$ jar -tvf ./eds/modeshape/client/modeshape-client.jar | grep LICENSE
 11560 Sat Jul 10 16:13:08 EDT 2004 META-INF/LICENSE_commons-codec.txt
 11358 Mon Nov 19 00:16:46 EST 2007 META-INF/LICENSE_commons-logging.txt
 11358 Tue Aug 11 20:51:16 EDT 2009 META-INF/LICENSE_httpclient.txt
 11358 Sun Jun 21 13:08:04 EDT 2009 META-INF/LICENSE_httpcore.txt
 10766 Mon Apr 20 18:50:44 EDT 2009 META-INF/LICENSE_jettison.txt
 11366 Tue Mar 30 23:14:34 EDT 2010 META-INF/LICENSE_log4j.txt
[ldimaggi@ldimaggi jboss-soa-p-5]$ jar -tvf ./eds/modeshape/client/modeshape-client.jar | grep NOTICE
   541 Mon Nov 19 00:16:46 EST 2007 META-INF/NOTICE_commons-logging.txt
   163 Tue Aug 11 20:51:16 EDT 2009 META-INF/NOTICE_httpclient.txt
   161 Sun Jun 21 13:08:04 EDT 2009 META-INF/NOTICE_httpcore.txt
   160 Tue Mar 30 23:14:34 EDT 2010 META-INF/NOTICE_log4j.txt