Bug 780407 (SOA-2838)

Summary: A call to Property#getDefinition returns null for new property nodes which are based on a replicated PropertyDefinition.
Product: [JBoss] JBoss Enterprise SOA Platform 5 Reporter: Marek Baluch <mbaluch>
Component: EDSAssignee: Van Halbert <vhalbert>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: high    
Version: 5.1.0.ER7CC: rhauch
Target Milestone: ---   
Target Release: 5.1.0.ER8   
Hardware: Unspecified   
OS: Unspecified   
URL: http://jira.jboss.org/jira/browse/SOA-2838
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-02-01 14:22:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Marek Baluch 2011-01-21 16:03:47 UTC
project_key: SOA

See linked issue.

Comment 1 Marek Baluch 2011-01-21 16:04:33 UTC
Link: Added: This issue depends MODE-1083


Comment 2 Randall Hauch 2011-01-21 18:03:28 UTC
I've found the problem. ModeShape's NodeTypeManager implementation caches maps of the property and child node definitions (keyed by their internal identifier), and this map was not being updated when the manager was being notified of changes to the node types (from other members of the cluster). The simple fix is to update these cached maps in the same logic where the manager is already processing the notifications.

This error will prove to be a problem in all clustered configurations, and thus is a fairly significant issue. Luckily, the change is quite minor and isolated to the RepositoryNodeTypeManager class, and only occurs when the engine is in a clustered environment. See MODE-1083 for details.

Comment 3 Randall Hauch 2011-01-21 21:12:09 UTC
For the record, as part of MODE-1083, I've created a pull-request to describe the proposed changes to the code: https://github.com/ModeShape/modeshape/pull/10

I'm currently waiting for approval to merge to the '2.2.x' branch before I do so on the 'master' branch. 

Comment 4 Randall Hauch 2011-01-21 21:13:34 UTC
(If you're not familiar with GitHub, click on the "Files Changed" tab to see the proposed changes. Feel free to comment on the pull-request. 

Comment 5 Randall Hauch 2011-01-21 21:28:49 UTC
After approval by Van, I've merged the proposed changes from MODE-1083 onto the 'master' and '2.2.x' branches, and marked MODE-183 as resolved.

Comment 7 Marek Baluch 2011-02-01 14:22:39 UTC
Verified on ER8.