Bug 780577 (SOA-3013)

Summary: HttpRouter action does not propagate exceptions
Product: [JBoss] JBoss Enterprise SOA Platform 4 Reporter: Rick Wagner <rwagner>
Component: JBossESBAssignee: tcunning
Status: CLOSED NEXTRELEASE QA Contact:
Severity: urgent Docs Contact:
Priority: urgent    
Version: 4.3 CP04 GACC: rwagner
Target Milestone: ---   
Target Release: 4.3 CP05, 4.3 CP05 ER2   
Hardware: Unspecified   
OS: Unspecified   
URL: http://jira.jboss.org/jira/browse/SOA-3013
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
All JBoss ESB 4.3.x
Last Closed: 2011-05-04 23:11:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
ebws_proxy.tar.bz2 none

Description Rick Wagner 2011-04-07 13:13:14 UTC 
Help Desk Ticket Reference: https://c.na7.visual.force.com/apex/Case_View?id=500A0000006n9NI&sfdc.override=1
SourceForge Reference: http://fisheye.jboss.org/viewrep/JBossESB/trunk/product/rosetta/src/org/jboss/soa/esb/actions/routing/http/HttpRouter.java?r1=29277&r2=30080&u=3
Steps to Reproduce: Use an HTTP Router with a non-existent URL.  You should see an Error in the log, but the Action Pipeline won't know any different.
project_key: SOA
Comment 1 Rick Wagner 2011-04-08 13:19:18 UTC 
Please vote for inclusion of this JIRA.

Thanks,

Rick
Comment 2 Anne-Louise Tangring 2011-04-08 14:15:13 UTC 
Approved for SOA 4.3 CP05
Comment 3 tcunning 2011-04-08 20:24:28 UTC 
Link: Added: This issue Cloned from JBESB-3599
Comment 4 tcunning 2011-04-08 20:29:09 UTC 
Release Notes Text: Added: Changed printStackTraces to throw new exceptions so that exceptions are propagated up.
Comment 5 tcunning 2011-04-08 20:29:40 UTC 
Changed printStackTraces to throw new exceptions so that exceptions are propagated up.
Comment 6 tcunning 2011-04-08 20:29:40 UTC 
Release Notes Text: Removed: Changed printStackTraces to throw new exceptions so that exceptions are propagated up.
Comment 7 Martin Vecera 2011-04-19 12:22:14 UTC 
The issue is still present in SOA-P 4.3 CP05 ER2
Comment 8 Martin Vecera 2011-04-19 12:23:58 UTC 
Attached a reproducer. Run ant deploy, ant runtest. There is an invalid URL in HttpRouter. After HttpRouter there is an echo action that should not be executed according to information in project JIRA.
Comment 9 Martin Vecera 2011-04-19 12:23:58 UTC 
Attachment: Added: ebws_proxy.tar.bz2
Comment 10 tcunning 2011-04-19 15:18:29 UTC 
The test case below does not hit either of the catch cases that were switched from e.printStackTrace -> throw new ActionProcessingException.      It doesn't really apply to this bug or the client case attached.

Changing the behavior of HttpRouter to throw an Exception on a non-successful http code is outside the scope of this bug and the client case attached to it.      You could file a separate issue against that, but I believe the warning message in that case is intended behavior.
Comment 11 Martin Vecera 2011-04-20 12:50:24 UTC 
As we discussed the issue with Tom, this is really resolved in 4.3 CP05 ER2.
Comment 12 Martin Vecera 2011-04-21 08:35:50 UTC 
Link: Added: This issue relates to SOA-3039
Comment 13 David Le Sage 2011-05-04 22:59:44 UTC 
Temporarily reopening to update release note info.
Comment 14 David Le Sage 2011-05-04 23:01:52 UTC 
Release Notes Docs Status: Added: Not Yet Documented
Writer: Added: dlesage
Comment 15 David Le Sage 2011-05-04 23:11:45 UTC 
Release Notes Docs Status: Removed: Not Yet Documented Added: Documented as Resolved Issue
Release Notes Text: Added: https://issues.jboss.org/browse/SOA-3013

The org/jboss/soa/esb/actions/routing/http/HttpRouter.java process() method was logging exceptions in stderr but not propagating them back to the action chain.  As a result of this, there is no indication that an invalid URL was used.  To fix this problem, printStackTraces has been modified so that it now throws new exceptions back to the action chain.  Therefore, users will now see that an invalid URL was used as they will encounter an error.