Bug 780951 (SOA-3418)

Summary: modeshape DDL scripts problem
Product: [JBoss] JBoss Enterprise SOA Platform 5 Reporter: Aleksandar Kostadinov <akostadinov>
Component: EDSAssignee: Van Halbert <vhalbert>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: high    
Version: 5.2.0.ER4CC: akostadinov, vhalbert
Target Milestone: ---   
Target Release: 5.2.0 GA   
Hardware: Unspecified   
OS: Unspecified   
URL: http://jira.jboss.org/jira/browse/SOA-3418
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-11-08 00:48:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Aleksandar Kostadinov 2011-09-27 15:28:18 UTC
project_key: SOA

There is some problem with modeshape DDL scripts for postgresql and oracle in 5.2 ER4. I ran test suite multiple times with different options but result is the same[1]. When I run the repo with autogenerate schema enabled, then tests pass with all databases.

On the jenkins link below you can find server logs and configuration files used to setup repos. Server has been restarted between each repo changes made (although this makes no difference compared to admin console -> reload of modeshape component). Unfortunately I can't see any exceptions related to the problem in the log. The repos seem just not deployed.

[1] https://hudson.qa.jboss.com/hudson/view/SOA-Release/job/soa-modeshape-ddl/143/

Comment 1 Van Halbert 2011-09-28 13:25:34 UTC
I'm not sure what was the problem in #143 above, but it seems to have worked itself out in https://hudson.qa.jboss.com/hudson/view/SOA-Release/job/soa-modeshape-ddl/144/.   It succeeded.

Comment 2 Aleksandar Kostadinov 2011-09-28 19:56:59 UTC
Hey Van, it was far from fixing by itself ;)
On each build page you can click "Parameters" and see what parameters have been set for the build.

With 114 I verified that autogenerateschema makes tests pass. With the builds before it I verified that without the option, pgsql and oracle fail.

Comment 3 Van Halbert 2011-09-29 14:06:04 UTC
As I'm testing this, I realized the ddl scripts were changed for postgresql and oracle because of a jbpm schema collision with using sequencing.   As noted in the create_sequence.modeshape-jpa-connector.ddl script:

 WARNING:  Running this script could fail if jBPM and ModeShape are sharing the 
           same database schema, and jBPM has already created the sequence

I wonder if your tests setup is executing both (2) ddl scripts for these databases?  

The 2 scripts to run are:   create.modeshape-jpa-connector.ddl and create_sequence.modeshape-jpa-connector.ddl 
This was done as a result of SOA-3187.

Comment 4 Aleksandar Kostadinov 2011-09-29 18:47:25 UTC
No, I'm not running both scripts. I can't understand what's the point in having the scripts split out? It seems like you need to execute both to have the repository working, correct? So why make it harder by splitting into two files?

In case there is a very good reason for the split, then is there any order required when executing the files?

Thank you!

Comment 5 Van Halbert 2011-09-29 18:58:26 UTC
As logged in SOA-3187, there's an issue if jBPM and ModeShape are sharing the same database.   This is the reason for the "create sequence" being separated so the user has the option not to execute that statement.   The was the option chosen after a group discussion on the issue.

Comment 6 Aleksandar Kostadinov 2011-09-29 19:05:29 UTC
Excuse me if missed something but such a decision can only make sense if modeshape repo can work without the problematic DDL script. But it seems like it cannot, so how is separating the files helping here? As far as I see user just needs to be made aware to not use modeshape an jBPM on the same DB.

Please also tell me if order of execution of the two scripts should matter.

Comment 7 Van Halbert 2011-09-29 19:16:59 UTC
order of execution doesn't matter.

Comment 9 Aleksandar Kostadinov 2011-10-01 05:13:41 UTC
Thank you Van, when execting all SQL, modeshape seems to be working fine. Even DB2!

Comment 10 David Le Sage 2011-11-08 00:47:56 UTC
Temporarily reopening for release note status.

Comment 11 David Le Sage 2011-11-08 00:48:17 UTC
Release Notes Docs Status: Added: Not Required
Writer: Added: dlesage