Bug 780977 (SOA-3446)

Summary: JBossWS-CXF unit tests broken classpath
Product: [JBoss] JBoss Enterprise SOA Platform 5 Reporter: Martin Vecera <mvecera>
Component: JBossWS, Build ProcessAssignee: Julian Coleman <jcoleman>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: urgent Docs Contact:
Priority: urgent    
Version: 5.2.0.ER4CC: asoldano, mvecera
Target Milestone: ---   
Target Release: 5.2.0 GA, 5.2.0.ER6   
Hardware: Unspecified   
OS: Unspecified   
URL: http://jira.jboss.org/jira/browse/SOA-3446
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-11-03 08:14:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
jbossws-cxf-SOA-3446.patch none

Description Martin Vecera 2011-10-06 12:08:35 UTC 
project_key: SOA

Around 14 JBossWS-CXF unit tests use class org.springframework.asm.ClassVisitor from spring-asm-jar. There has been a change recently that split the spring jar into several modules. The new modules are in client directory of SOA-P. It seems that JBossWS-CXF unit tests do not have this spring-asm.jar on the classpath:

java.lang.NoClassDefFoundError: org/springframework/asm/ClassVisitor
	at org.springframework.context.support.AbstractRefreshableApplicationContext.customizeBeanFactory(AbstractRefreshableApplicationContext.java:218)
	at org.springframework.context.support.AbstractRefreshableApplicationContext.refreshBeanFactory(AbstractRefreshableApplicationContext.java:129)
	at org.springframework.context.support.AbstractApplicationContext.obtainFreshBeanFactory(AbstractApplicationContext.java:467)
	at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:397)
	at org.apache.cxf.bus.spring.BusApplicationContext.<init>(BusApplicationContext.java:91)
	at org.apache.cxf.bus.spring.SpringBusFactory.createApplicationContext(SpringBusFactory.java:102)
	at org.apache.cxf.bus.spring.SpringBusFactory.createBus(SpringBusFactory.java:93)
	at org.apache.cxf.bus.spring.SpringBusFactory.createBus(SpringBusFactory.java:86)
	at org.apache.cxf.bus.spring.SpringBusFactory.createBus(SpringBusFactory.java:64)
	at org.apache.cxf.bus.spring.SpringBusFactory.createBus(SpringBusFactory.java:53)
	at org.apache.cxf.BusFactory.getDefaultBus(BusFactory.java:90)
	at org.apache.cxf.BusFactory.getDefaultBus(BusFactory.java:79)
	at org.apache.cxf.tools.common.toolspec.AbstractToolContainer.getBus(AbstractToolContainer.java:189)
	at org.apache.cxf.tools.wsdlto.WSDLToJavaContainer.processWsdl(WSDLToJavaContainer.java:158)
	at org.apache.cxf.tools.wsdlto.WSDLToJavaContainer.execute(WSDLToJavaContainer.java:128)
	at org.apache.cxf.tools.wsdlto.WSDLToJavaContainer.execute(WSDLToJavaContainer.java:271)
	at org.apache.cxf.tools.common.toolspec.ToolRunner.runTool(ToolRunner.java:103)
	at org.apache.cxf.tools.wsdlto.WSDLToJava.run(WSDLToJava.java:113)
	at org.apache.cxf.tools.wsdlto.WSDLToJava.run(WSDLToJava.java:86)
	at org.jboss.wsf.stack.cxf.tools.CXFConsumerImpl.consume(CXFConsumerImpl.java:232)
	at org.jboss.wsf.spi.tools.cmd.WSConsume.importServices(WSConsume.java:230)
	at org.jboss.wsf.spi.tools.cmd.WSConsume.main(WSConsume.java:81)
Caused by: java.lang.ClassNotFoundException: org.springframework.asm.ClassVisitor
	at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:307)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:248)
	... 22 more
Comment 1 Martin Vecera 2011-10-12 07:56:30 UTC 
Sources are from here: https://brewweb.devel.redhat.com/buildinfo?buildID=181265

Alessio clarified to me that he already provided a patch for this to Fernando. Obviously it is not present in the above mentioned source code.

Could you please provide valid SVN repository and tag for the sources? We need this to certify SOA-P 5.2 and give green light to release.
Comment 2 Julian Coleman 2011-10-12 10:14:16 UTC 
Link: Added: This issue incorporates SOA-3160
Comment 3 Julian Coleman 2011-10-12 10:15:29 UTC 
Link: Added: This issue depends JBPAPP-7009
Comment 4 Julian Coleman 2011-10-12 10:15:57 UTC 
Link: Removed: This issue depends JBPAPP-7009
Comment 5 Julian Coleman 2011-10-12 10:16:08 UTC 
Link: Removed: This issue incorporates SOA-3160
Comment 6 Alessio Soldano 2011-10-13 11:13:15 UTC 
I've spent hours on reproducing the test environment that's on hudson, to finally find out that the problem is simply https://issues.jboss.org/browse/SOA-3319 as mentioned on IRC to Martin. You need to apply that patch.
Comment 7 Alessio Soldano 2011-10-13 11:14:23 UTC 
IOW the failures due to spring CNFE are caused by the lack of the new spring jars in wsprovide.sh/wsrunclient.sh/... scripts. The jbossws testsuite is fine.
Comment 8 Aleksandar Kostadinov 2011-10-20 12:48:42 UTC 
Link: Added: This issue is related to SOA-3319
Comment 9 David Le Sage 2011-10-21 06:00:17 UTC 
Release Notes Docs Status: Added: Not Required
Writer: Added: dlesage
Comment 10 Martin Vecera 2011-10-21 08:39:59 UTC 
This is still not fully fixed in ER5, waiting for ER6...
Comment 11 Julian Coleman 2011-10-21 13:42:04 UTC 
Patch for wsconsume.* and unit tests (addition to the patch from SOA-3319).
Incorporated in buildId 184593.
Comment 12 Julian Coleman 2011-10-21 13:42:04 UTC 
Attachment: Added: jbossws-cxf-SOA-3446.patch
Comment 13 Martin Vecera 2011-10-23 16:42:35 UTC 
Link: Added: This issue relates to SOA-3511
Comment 14 Len DiMaggio 2011-10-24 15:17:40 UTC 
Link: Added: This issue relates to SOA-3501
Comment 15 Julian Coleman 2011-10-24 15:43:12 UTC 
Resolved.  New issues in SOA-3511.
Comment 16 Martin Vecera 2011-11-03 08:14:19 UTC 
Verified with ER6