Bug 781317

Summary: [Text] Node type is RHEL when node is Fedora
Product: [Retired] oVirt Reporter: Jakub Libosvar <jlibosva>
Component: vdsmAssignee: Dan Kenigsberg <danken>
Status: CLOSED CURRENTRELEASE QA Contact: yeylon <yeylon>
Severity: medium Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: abaron, acathrow, bazulay, hateya, iheim, srevivo, ykaul
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-03-11 16:04:31 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
engine log none

Description Jakub Libosvar 2012-01-13 09:47:40 UTC
Created attachment 555023 [details]
engine log

Description of problem:
When host has Fedora 16 installed, in webadmin in general info, OS Version is "RHEL - 16 -1". Even in api <type>rhel</type>

Version-Release number of selected component (if applicable):
ovirt-engine-backend-3.0.0_0001-7.fc16.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Install Fedora host
2. Check OS version of installed host
  
Actual results:
RHEL - 16 -1

Expected results:
FEDORA 16

Additional info:
During installation, host was recognized correctly:
<BSTRAP component='OS' status='OK' type='FEDORA' message='Supported platform version'/>

Comment 1 Yaniv Kaul 2012-01-13 09:53:05 UTC
What do you see in VDSM's getVdsCaps?

Comment 2 Jakub Libosvar 2012-01-13 10:19:47 UTC
(In reply to comment #1)
> What do you see in VDSM's getVdsCaps?

You are right, changing component to vdsm:
operatingSystem = {'release': '1', 'version': '16', 'name': 'RHEL'}

vdsm-4.9.2-0.65.gitf945dc2.fc16.x86_64

[root@srh-03 vdsm]# cat /etc/redhat-release 
Fedora release 16 (Verne)

[root@srh-03 vdsm]# ll /etc/ovirt-node-image-release
ls: cannot access /etc/ovirt-node-image-release: No such file or directory

From caps.py:
127 def getos():
128     if os.path.exists('/etc/rhev-hypervisor-release'):
129         return OSName.RHEVH
130     elif os.path.exists('/etc/ovirt-node-image-release'):
131         return OSName.OVIRT
132     elif os.path.exists('/etc/redhat-release'):
133         return OSName.RHEL
134     else:
135         return OSName.UNKNOWN

Comment 3 Itamar Heim 2012-01-14 12:02:24 UTC
need to make sure changing this in vdsm doesn't break engine...

Comment 4 Haim 2012-01-15 14:23:07 UTC
http://gerrit.ovirt.org/#change,1048

Comment 5 Haim 2012-01-15 14:23:22 UTC
(In reply to comment #3)
> need to make sure changing this in vdsm doesn't break engine...

tested, it doesn't