Bug 781642

Summary:	Default helper applications (alsamixer and xterm)
Product:	[Fedora] Fedora	Reporter:	Raphael Groner <projects.rg>
Component:	volumeicon	Assignee:	Christoph Wickert <christoph.wickert>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	16	CC:	christoph.wickert
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:	volumeicon-0.4.5-3.fc16	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-02-12 22:47:44 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Raphael Groner 2012-01-14 00:29:27 UTC

Description of problem:
The package volumeicon should depend on alsamixer (in alsa-utils) and xterm. Otherwise, volumeicon would behave misleading cause xterm and alsamixer are used in the default configuration.

Version-Release number of selected component (if applicable):
volumeicon-0.4.1-3.fc16.x86_64

How reproducible:
yes

Steps to Reproduce:
1. yum install -y volumeicon && yum remove -y xterm alsa-utils
2. call volumeicon
3. right click on systray icon and select "Open mixer"
  
Actual results:
If xterm and alsamixer aren't installed, there's no useful effect for "Open mixer" context menu entry.

Expected results:
xterm and alsamixer should be noticed to the user at least as the default helper applications. Better set them as required dependencies for the package.

Additional info:
Maybe it's a good idea to use the individual mixer of the installed desktop instead of alsamixer running in xerm, for instance xfce4-mixer.
A similiar issue is given by streamtuner. It has audacious and xterm as default helpers and therefore both are set as package dependencies. What if the user likes to use another player instead of audacious and get rid of the latter?

Comment 1 Raphael Groner 2012-01-14 00:42:01 UTC

See bug # 216962 why streamtuner (another package) depends on audacious. Maybe due to historical reason.

There should be at least a message to the user why mixer can't be started.

Comment 2 Christoph Wickert 2012-01-14 14:25:29 UTC

(In reply to comment #0)
> Description of problem:
> The package volumeicon should depend on alsamixer (in alsa-utils) and xterm. 
> Otherwise, volumeicon would behave misleading cause xterm and alsamixer are
> used in the default configuration.

In fact the default config should be patched to use pavucontrol and AFAIR I did that.

> If xterm and alsamixer aren't installed, there's no useful effect for "Open
> mixer" context menu entry.

There is a context menu entry, it just doesn't work if the configured mixer is not installed. However I don't think that I should add a dependency here because this is completely optional. Too bad rpm doesn't support "Recommends" yet.

> Maybe it's a good idea to use the individual mixer of the installed desktop
> instead of alsamixer running in xerm, for instance xfce4-mixer.

How would you want to achieve that? I have no control over what desktop people use.

Comment 3 Raphael Groner 2012-01-14 17:01:16 UTC

(In reply to comment #2)
> In fact the default config should be patched to use pavucontrol and AFAIR I did
> that.

I can't find a corresponding patch in the package.

> How would you want to achieve that? I have no control over what desktop people
> use.

volumeicon should check for a return value of the called sub process and display a nice warning box if no success would have been detected. I don't think that the user will suspect a wrong configuration to fix by itself if there's no senseful effect for its click.

Thanks for support.

Comment 4 Fedora Update System 2012-01-28 13:22:35 UTC

volumeicon-0.4.5-3.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/volumeicon-0.4.5-3.fc16

Comment 5 Christoph Wickert 2012-01-28 13:25:42 UTC

Please note that this update only changes the default configuration to use pavucontrol but does not add artificial hardcoded dependencies.

As for the popup if the configured mixer is not found: This is a feature request and I will discuss it with upstream, but not as part of this bug report.

Comment 6 Fedora Update System 2012-01-28 20:57:53 UTC

Package volumeicon-0.4.5-3.fc16:
* should fix your issue,
* was pushed to the Fedora 16 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing volumeicon-0.4.5-3.fc16'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-1017/volumeicon-0.4.5-3.fc16
then log in and leave karma (feedback).

Comment 7 Raphael Groner 2012-01-29 12:26:05 UTC

Thanks for the update.

(In reply to comment #5)
> As for the popup if the configured mixer is not found: This is a feature
> request and I will discuss it with upstream, but not as part of this bug
> report.

That's fine. When you run volumeicon from a terminal, there's an error of shell that the command, e.g. pavucontrol, couldn't be found. (In case of malfunction, it's always good to run an application for debugging purpose in terminal and hopefully see some error text. :) )

Comment 8 Fedora Update System 2012-02-12 22:47:44 UTC

volumeicon-0.4.5-3.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.