Bug 782088

Summary: [glusterfs-3.2.6qa1]: io-cache reconfigure gives warning messages for other xlator options also
Product: [Community] GlusterFS Reporter: Raghavendra Bhat <rabhat>
Component: io-cacheAssignee: Raghavendra Bhat <rabhat>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: pre-releaseCC: amarts, gluster-bugs, vbellur
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-11-29 11:18:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Raghavendra Bhat 2012-01-16 13:49:18 UTC
Description of problem:
volume set option is giving the warning messages saying data is NULL in the reconfigure section of io-cache xlator. set command was for write-behind to turn off/on the flush-behind option.

In io-cache reconfigure we are doing this.

tmp = data_to_str (dict_get (options, "min-file-size"));

data_to_str is giving the warning, since it cannot find the value for the provided key. Those messages can be stopped by using dict_get_str instead of doing data_to_str (dicy_get), which other xlators are doing.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.volume set command to change performance xlator options.
2.
3.
  
Actual results:
volume '/mnt/sda7/export4'.
[2012-01-16 18:53:51.460541] I [fuse-bridge.c:3339:fuse_graph_setup] 0-fuse: switched to graph 0
[2012-01-16 18:53:51.460747] I [fuse-bridge.c:2927:fuse_init] 0-glusterfs-fuse: FUSE inited with protocol versions: glusterfs 7.13 kernel 7.16
[2012-01-16 18:53:56.939448] I [glusterfsd-mgmt.c:62:mgmt_cbk_spec] 0-mgmt: Volume file changed
[2012-01-16 18:53:57.985423] W [write-behind.c:2957:reconfigure] 0-vol-write-behind: disabling flush-behind
[2012-01-16 18:53:57.985649] W [dict.c:1153:data_to_str] (-->/usr/local/lib/libglusterfs.so.0(+0x1f28e) [0x7f8606ce828e] (-->/usr/local/lib/li
bglusterfs.so.0(+0x1f363) [0x7f8606ce8363] (-->/usr/local/lib/glusterfs/3.2git/xlator/performance/io-cache.so(reconfigure+0x839) [0x7f86031db6
47]))) 0-dict: data is NULL
[2012-01-16 18:53:57.985703] W [dict.c:1153:data_to_str] (-->/usr/local/lib/libglusterfs.so.0(+0x1f28e) [0x7f8606ce828e] (-->/usr/local/lib/li
bglusterfs.so.0(+0x1f363) [0x7f8606ce8363] (-->/usr/local/lib/glusterfs/3.2git/xlator/performance/io-cache.so(reconfigure+0x865) [0x7f86031db6
73]))) 0-dict: data is NULL
[2012-01-16 18:57:52.733258] I [fuse-bridge.c:3241:fuse_thread_proc] 0-fuse: unmounting /mnt/client
[2012-01-16 18:57:52.733774] W [glusterfsd.c:727:cleanup_and_exit] (-->/lib/x86_64-linux-gnu/libc.so.6(clone+0x6d) [0x7f86061c304d] (-->/lib/x
86_64-linux-gnu/libpthread.so.0(+0x6d8c) [0x7f8606477d8c] (-->/usr/local/sbin/glusterfs(glusterfs_sigwaiter+0xea) [0x406ad2]))) 0-: received s
ignum (15), shutting down
[2012-01-16 18:57:56.127455] I [glusterfsd.c:1493:main] 0-/usr/local/sbin/glusterfs: Started running /usr/local/sbin/glusterfs version 3.2git
[2012-01-16 18:57:56.140773] W [write-behind.c:3023:init] 0-vol-write-behind: disabling write-behind for first 0 bytes
[2012-01-16 18:57:56.142392] I [client.c:1935:notify] 0-vol-client-0: parent translators are ready, attempting connect on transport


Expected results:


Additional info:

Comment 1 Amar Tumballi 2012-03-25 09:13:59 UTC
Is it still valid? can we have resolution to this bug?

Comment 2 Raghavendra Bhat 2012-03-26 07:43:40 UTC
This patch has been sent to fix the issue. It has to be reviewed and accepted.
http://review.gluster.com/#change,2673

Comment 3 Amar Tumballi 2012-11-21 10:08:00 UTC
is this still valid? can we close it if its fixed in 3.3.0 (or higher) versions?

Comment 4 Amar Tumballi 2012-11-29 11:18:26 UTC
not valid on 3.3.x or higher versions. Closing the issue as CURRENTRELEASE