| Summary: | sipcalc buffer overflow | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | IanB <bugzilla.blk> |
| Component: | sipcalc | Assignee: | Jaromír Cápík <jcapik> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 15 | CC: | dwmw2, jcapik, jwacaser, ovasik |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | sipcalc-1.1.5-1.fc15 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-03-01 09:23:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
IanB
2012-01-17 07:11:03 UTC
I've grabbed the source RPM sipcalc-1.1.4-5.fc15.src.rpm and compiled sipcalc using the source code there. When I run that instance of sipcalc, it does not dump core but fails gracefully: $ ./sipcalc 1 -[int-ipv4 : 1] - 0 -[ERR : Unable to retrieve interface information] - $ Hello. I can reproduce the issue here. The problem is not present when I try to run the configure script without using the %configure macro and when I pass just the --prefix argument. But that doesn't mean there is no bug in the sources. The final binary is just a little different, what's sometimes sufficient to fully mask the root cause while it's still present. I'm gonna do a deeper analysis. Thanks for reporting. Regards, Jaromir. I just found the bug ... Writing up to 127 bytes to a 64 bytes long buffer is not very safe. I'm going to fix that. The fixed component will be available soon. BR, J. Do You need the fixed component in Fedora 15? The fix is currently built for Fedora Rawhide (=17) only. If You need this fix available in Fedora 15 (or 16), then let me know asap, please. Thanks in advance. Regards, Jaromir. This is not critical for me and I'm happy to use the instance of sipcalc that I compiled. It would be nice for other people to have this fixed in the RPMs for FC15,16 (if it's not too much trouble). I had to patch the source code heavily, since many string manipulations were unsafe. Therefore I'd like people to test the changes first. It would be nice if You could download and test the f17 version and try as many reasonable combinations of input values and switches as possible. There might be unwanted differences in the output which I haven't noticed yet. Please, let me know if You could do that. Thank You. Regards, Jaromir. Not comprehensive, but the following appear to be handled gracefully while previously they generated buffer overflows. Further, tested several with valid subnets to ensure results were as expected without seeing an issue. [jwacase@fsa ~]$ rpm -qi sipcalc | grep -i rpm Source RPM : sipcalc-1.1.5-1.fc17.src.rpm 1060 sipcalc /? 1061 sipcalc 192.168.1.1/33 1062 sipcalc 192.168.1.1 /23 1063 sipcalc 0:::0 1066 sipcalc 0::0 /120 1067 sipcalc 192.168.1.1-24 1068 sipcalc 192.168.1.1:24 Hello Jeffrey. Thanks for the feedback. I'm considering the changes as working and going to propagate them to older releases of Fedora. sipcalc-1.1.5-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/sipcalc-1.1.5-1.fc16 sipcalc-1.1.5-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/sipcalc-1.1.5-1.fc15 (In reply to comment #8) > Hello Jeffrey. > > Thanks for the feedback. > I'm considering the changes as working and going to propagate them to older > releases of Fedora. Thankyou :) Package sipcalc-1.1.5-1.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing sipcalc-1.1.5-1.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-1666/sipcalc-1.1.5-1.fc16 then log in and leave karma (feedback). sipcalc-1.1.5-1.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. sipcalc-1.1.5-1.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. |