Bug 782716

Summary:	Change interface parameters with '{in,out}bound' option will crash libvirtd
Product:	Red Hat Enterprise Linux 6	Reporter:	Alex Jia <ajia>
Component:	libvirt	Assignee:	Michal Privoznik <mprivozn>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	high	Docs Contact:
Priority:	high
Version:	6.3	CC:	acathrow, dallan, dyuan, mshao, mzhan, rwu
Target Milestone:	rc
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	libvirt-0.9.10-1.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-06-20 06:46:53 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Alex Jia 2012-01-18 09:07:21 UTC

Description of problem:
when changing interface parameters with 'inbound' or 'outbound' option on first time, libvirtd will be crashed.

Version-Release number of selected component (if applicable):
# rpm -q libvirt
libvirt-0.9.9-1.el6.x86_64

How reproducible:
always

Steps to Reproduce:
# virsh start foo
Domain demo started

# virsh domiftune foo vnet0
inbound.average: 0
inbound.peak   : 0
inbound.burst  : 0
outbound.average: 0
outbound.peak  : 0
outbound.burst : 0

# virsh domiftune foo vnet0 --inbound 10000
error: Unable to set interface parameters
error: End of file while reading data: Input/output error

or 

# virsh domiftune demo vnet0 --outbound 10000

# service libvirtd status
libvirtd dead but pid file exists

Note, it's okay if I change them together on the first time then do separated change for inbound or outbound:
# virsh domiftune foo vnet0 --inbound 10000 --outbound 20000

# virsh domiftune foo vnet0
inbound.average: 10000
inbound.peak   : 0
inbound.burst  : 0
outbound.average: 20000
outbound.peak  : 0
outbound.burst : 0

# virsh domiftune foo vnet0 --inbound 30000

# virsh domiftune foo vnet0
inbound.average: 30000
inbound.peak   : 0
inbound.burst  : 0
outbound.average: 20000
outbound.peak  : 0
outbound.burst : 0

  
Actual results:
# service libvirtd status
libvirtd dead but pid file exists

Expected results:
can separately change inbound or outbound for interface device.

Additional info:
it should be the same issue with bug 771562.

Comment 1 Alex Jia 2012-01-18 09:11:48 UTC

The above comments exist copy-paste error, s/demo/foo/, I verified this issue on different guests(demo and foo) then cross to paste them :(

Comment 2 Michal Privoznik 2012-01-31 16:16:24 UTC

Patch sent upstream:

https://www.redhat.com/archives/libvir-list/2012-January/msg01435.html

Comment 3 Michal Privoznik 2012-02-01 08:08:28 UTC

Pushed upstream, moving to POST:

commit 50e9b389306ce845076806b9e9f6da1dc9a746da
Author:     Michal Privoznik <mprivozn>
AuthorDate: Tue Jan 31 13:43:56 2012 +0100
Commit:     Michal Privoznik <mprivozn>
CommitDate: Wed Feb 1 08:56:54 2012 +0100

    qemu: Clenup qemuDomainSetInterfaceParameters
    
    which contained some useless lines, copied code, NULL
    dereference.

v0.9.9-179-g50e9b38

Comment 6 xhu 2012-02-15 05:36:19 UTC

Reproduce it with libvirt-0.9.9-1.el6.x86_64.
Verify it with libvirt-0.9.10-1.el6 and it passed.

Comment 8 errata-xmlrpc 2012-06-20 06:46:53 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-0748.html