Bug 782839
Summary: | Cumin should report changes in condor pool as INFO (instead ERROR) | ||
---|---|---|---|
Product: | Red Hat Enterprise MRG | Reporter: | Stanislav Graf <sgraf> |
Component: | cumin | Assignee: | Trevor McKay <tmckay> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Peter Belanyi <pbelanyi> |
Severity: | unspecified | Docs Contact: | |
Priority: | low | ||
Version: | 2.1 | CC: | athomas, esammons, matt, mkudlej, pbelanyi, tmckay |
Target Milestone: | 3.0 | Keywords: | Reopened |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | cumin-0.1.5251-1 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-05-06 13:52:23 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Stanislav Graf
2012-01-18 16:33:17 UTC
Fixed in revision 5218. All log.exception(e) calls have been changed to the form log.debug(msg, exc_info=True). This will remove all exception traces from log files unless the logging level is set to debug. None of these traces was useful to users in general, and in all cases the exception was already being handled (there were no cases of log.exception followed by a raise statement). imho, it is very difficult to do any testing around this beyond a careful code review of a diff against the previous revision. There is no way to inject exceptions in all of the various different places to test all execution paths without editing the code as a white box test to raise an exception in each affected block. According to comment 3 I did a code review of the diff between revision 5217 and 5218 of cumin. All log.exception calls have been changed to log.debug calls or something more suitable. --> VERIFIED |